Minor UI changes for sidebar and update to PPL request #1246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sean Li <[email protected]>
vmmusings
approved these changes
Nov 4, 2022
derek-ho
reviewed
Nov 4, 2022
| ); | ||
| const normalizedData = catalogData.jsonData.map((obj: any) => ({ | ||
| id: `${obj.TABLE_CATALOG}.${obj.TABLE_NAME}`, | ||
| name: `${obj.TABLE_CATALOG}.${obj.TABLE_NAME}`, | ||
| catalog: `${catalog.CATALOG_NAME}`, | ||
| catalog: `${dataSource.DATASOURCE_NAME}`, |
There was a problem hiding this comment.
do you want to change this to datasource?
There was a problem hiding this comment.
think I'll keep it as catalog for now, changing it would mess with Pratik's code for visualizations.
derek-ho
approved these changes
Nov 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sean Li [email protected]
Description
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.