Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor trace analytics in main to merge into observability #102

Conversation

joshuali925
Copy link
Member

@joshuali925 joshuali925 commented Aug 31, 2021

Description

This PR merges all commits in main branch and trace analytics components to observability branch.
The overall diff in this PR includes everything in the current trace analytics and might be too large to review. It would be easier to look at this diff f714958...1bb5888, which only includes commits to refactor current trace analytics to observability as a side bar item.

Unit and integration tests will be updated in a separate PR.

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

dependabot bot and others added 19 commits June 14, 2021 12:10
Bumps [glob-parent](https://github.com/gulpjs/glob-parent) from 5.1.1 to 5.1.2.
- [Release notes](https://github.com/gulpjs/glob-parent/releases)
- [Changelog](https://github.com/gulpjs/glob-parent/blob/main/CHANGELOG.md)
- [Commits](gulpjs/glob-parent@v5.1.1...v5.1.2)

---
updated-dependencies:
- dependency-name: glob-parent
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Add coverage

Signed-off-by: Joshua Li <[email protected]>

* Update workflow

Signed-off-by: Joshua Li <[email protected]>
…ject#57)

* Add releasing.md

Signed-off-by: Joshua Li <[email protected]>

* Add link checker workflow

Signed-off-by: Joshua Li <[email protected]>

* Fix broken links

Signed-off-by: Joshua Li <[email protected]>

* Add more docs

Signed-off-by: Joshua Li <[email protected]>

* Link contributing.md

Signed-off-by: Joshua Li <[email protected]>

* Add github token in link checker

Signed-off-by: Joshua Li <[email protected]>

* update developer_guide.md

Signed-off-by: Joshua Li <[email protected]>

* Rename artifact to kebab case

Signed-off-by: Joshua Li <[email protected]>

* Add badges

Signed-off-by: Joshua Li <[email protected]>
* Bump version to 1.0.0.0

Signed-off-by: Joshua Li <[email protected]>

* Add release notes

Signed-off-by: Joshua Li <[email protected]>

* Fix codecov badge link

Signed-off-by: Joshua Li <[email protected]>

* Update node version

Signed-off-by: Joshua Li <[email protected]>

* Update release notes

Signed-off-by: Joshua Li <[email protected]>

* Update CI

Signed-off-by: Joshua Li <[email protected]>

Fix CI

Signed-off-by: Joshua Li <[email protected]>
Signed-off-by: Joshua Li <[email protected]>
Signed-off-by: Joshua Li <[email protected]>
Signed-off-by: Joshua Li <[email protected]>
Signed-off-by: Joshua Li <[email protected]>
…/trace-analytics into feature/merge-trace-analytics
@joshuali925 joshuali925 self-assigned this Aug 31, 2021
Copy link
Collaborator

@mengweieric mengweieric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ps48 ps48 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments LGTM

public/components/trace_analytics/components/app.tsx Outdated Show resolved Hide resolved
@joshuali925 joshuali925 merged commit 09970db into opensearch-project:feature/observability Sep 1, 2021
joshuali925 pushed a commit to joshuali925/observability that referenced this pull request Jul 20, 2022
…issue

debuginfo: Ensure unused section removed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants