Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gradle to 8.10.2 #975

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Conversation

reta
Copy link
Contributor

@reta reta commented Oct 22, 2024

Description

Update Gradle to 8.10.2

Related Issues

N/A

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Andriy Redko <[email protected]>
@reta
Copy link
Contributor Author

reta commented Oct 22, 2024

Also needs backport to 2.x please

@yuye-aws
Copy link
Member

@reta Can you provide more context on why are we upgrading gradle?

@reta
Copy link
Contributor Author

reta commented Oct 23, 2024

@reta Can you provide more context on why are we upgrading gradle?

Thanks for looking @yuye-aws , there are at least 2 reasons:

  • support builds under JDK-23 (which main is already on)
  • keeping build tooling up to date

@yuye-aws
Copy link
Member

@reta Thanks for providing the context. Seems there are flakey tests now. Rerunning the CI now...

@yuye-aws
Copy link
Member

  • support builds under JDK-23 (which main is already on)

Is there going to be a JDK upgrade PR towards 23?

@reta
Copy link
Contributor Author

reta commented Oct 23, 2024

Is there going to be a JDK upgrade PR towards 23?

Yes, I didn't do it there since backport to 2.x will fail

Copy link
Member

@yuye-aws yuye-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good to me. CI fails due to flakey test on cluster health

@yuye-aws yuye-aws merged commit 7a4fcf8 into opensearch-project:main Oct 23, 2024
9 of 10 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 23, 2024
Signed-off-by: Andriy Redko <[email protected]>
(cherry picked from commit 7a4fcf8)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants