[Backport 2.10] Adds webhook format check for Slack #944
+105
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Microsoft teams (#676) * Added feature support for microsoft teams webhoo Signed-off-by: danielkyalo599 <[email protected]> * Added feature support for microsoft teams webhook ,removed valid webhooks Signed-off-by: danielkyalo599 <[email protected]> * Added feature support for Microsoft teams webhook Signed-off-by: danielkyalo599 <[email protected]> * Refactored feature support for ms teams and added unit and integTest Signed-off-by: danielkyalo599 <[email protected]> * fix build in core Signed-off-by: zhichao-aws <[email protected]> * fix core-spi build Signed-off-by: zhichao-aws <[email protected]> * fix notifications main code Signed-off-by: zhichao-aws <[email protected]> * fix mappings, add IT Signed-off-by: zhichao-aws <[email protected]> * add auto upgrade mapping logic Signed-off-by: zhichao-aws <[email protected]> * put load mapping to initialize step Signed-off-by: zhichao-aws <[email protected]> * add schema_version field Signed-off-by: zhichao-aws <[email protected]> * add integ test Signed-off-by: zhichao-aws <[email protected]> * adjust with auto upgrade mapping logic Signed-off-by: zhichao-aws <[email protected]> * add bwc Signed-off-by: zhichao-aws <[email protected]> * modify bwc Signed-off-by: zhichao-aws <[email protected]> * modify bwc Signed-off-by: zhichao-aws <[email protected]> * resolve comments Signed-off-by: zhichao-aws <[email protected]> * add license header Signed-off-by: zhichao-aws <[email protected]> * fix microsoft teams sample url in IT to adapt url validation Signed-off-by: zhichao-aws <[email protected]> --------- Signed-off-by: danielkyalo599 <[email protected]> Signed-off-by: zhichao-aws <[email protected]> Co-authored-by: danielkyalo599 <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Add microsoft teams validation error message (#746) * add validation failure message for Microsoft Teams Signed-off-by: zhichao-aws <[email protected]> * modify integtest Signed-off-by: zhichao-aws <[email protected]> --------- Signed-off-by: zhichao-aws <[email protected]> Signed-off-by: Aniruddh <[email protected]> * onboard system and hidden index (#742) Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Updates demo certs used in integ tests (#756) Signed-off-by: Darshit Chanpura <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Add 2.10.0 release notes (#755) * Add 2.10.0 release notes Signed-off-by: Hailong Cui <[email protected]> * update release notes Signed-off-by: Hailong Cui <[email protected]> * Update opensearch-notifications.release-notes-2.10.0.0.md Signed-off-by: Hailong Cui <[email protected]> * fix wrong PR number Signed-off-by: Hailong Cui <[email protected]> --------- Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: Aniruddh <[email protected]> * bump bwc version to 2.11 (#763) Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Add 2.11 release notes (#774) Signed-off-by: yuye-aws <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Fix integration test failure by allowing direct access to system index warning (#784) * Fix integration test failure by allowing direct access to system index warning Signed-off-by: gaobinlong <[email protected]> * Fix bwc test failure of throwing direct access to system index when getting mapping Signed-off-by: gaobinlong <[email protected]> --------- Signed-off-by: gaobinlong <[email protected]> Signed-off-by: Aniruddh Srivastava <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Re-enable detekt Bumped version of `io.gitlab.arturbosch.detekt:detekt-gradle-plugin` to `1.23.0` Signed-off-by: Aniruddh <[email protected]> Signed-off-by: Aniruddh Srivastava <[email protected]> Signed-off-by: Aniruddh <[email protected]> * bump bwc version to 2.12 (#793) Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: Aniruddh Srivastava <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Update dependency org.json:json to v20231013 (#795) Signed-off-by: gaobinlong <[email protected]> Signed-off-by: Aniruddh Srivastava <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Impove security plugin enabling check (#792) Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: Aniruddh Srivastava <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Add github workflow to auto bump bwc version (#799) * Adding bump bwc version github workflow Signed-off-by: Hailong Cui <[email protected]> * revert app id Signed-off-by: Hailong Cui <[email protected]> --------- Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: Aniruddh Srivastava <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Replace the TestMailServer to GreenMail server (#801) * Add 2.11 release notes (#774) Signed-off-by: yuye-aws <[email protected]> Signed-off-by: rdani <[email protected]> * Fix integration test failure by allowing direct access to system index warning (#784) * Fix integration test failure by allowing direct access to system index warning Signed-off-by: gaobinlong <[email protected]> * Fix bwc test failure of throwing direct access to system index when getting mapping Signed-off-by: gaobinlong <[email protected]> --------- Signed-off-by: gaobinlong <[email protected]> Signed-off-by: rdani <[email protected]> * Replace the TestMailServer to GreenMail server Signed-off-by: rdani <[email protected]> * bump bwc version to 2.12 (#793) Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: rdani <[email protected]> * Update dependency org.json:json to v20231013 (#795) Signed-off-by: gaobinlong <[email protected]> Signed-off-by: rdani <[email protected]> * Re-enable detekt (#796) Bumped version of `io.gitlab.arturbosch.detekt:detekt-gradle-plugin` to `1.23.0` Signed-off-by: Aniruddh <[email protected]> Co-authored-by: Hailong Cui <[email protected]> Signed-off-by: rdani <[email protected]> * Add assertion for retrieval of notification Signed-off-by: rdani <[email protected]> * Update to stable version Signed-off-by: rdani <[email protected]> * Update to stable version Signed-off-by: rdani <[email protected]> * Update to suggested version Signed-off-by: rdani <[email protected]> --------- Signed-off-by: yuye-aws <[email protected]> Signed-off-by: rdani <[email protected]> Signed-off-by: gaobinlong <[email protected]> Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: Aniruddh <[email protected]> Co-authored-by: Yuye Zhu <[email protected]> Co-authored-by: gaobinlong <[email protected]> Co-authored-by: rdani <[email protected]> Co-authored-by: Hailong Cui <[email protected]> Co-authored-by: Aniruddh <[email protected]> Signed-off-by: Aniruddh Srivastava <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Onboard prod jenkins docker image to github actions (#809) * Onboard prod jenkins docker image to github actions Signed-off-by: Peter Zhu <[email protected]> * Add more Signed-off-by: Peter Zhu <[email protected]> --------- Signed-off-by: Peter Zhu <[email protected]> Signed-off-by: Aniruddh Srivastava <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Added org.apache.logging.log4j:log4j-slf4j-impl to classpath (#791) * Added slf4j-jdk14.jar to classpath Adding binding for SLF4J that should fix StaticLoggerBinder being not loaded. Followed instructions from warning messages that appear. Signed-off-by: Noir <[email protected]> * Undid 80fc198 Removed slf4j-jdk14.jar from classpath Signed-off-by: Aniruddh <[email protected]> * Added org.apache.logging.log4j:log4j-slf4j-impl to classpath Signed-off-by: Aniruddh <[email protected]> --------- Signed-off-by: Noir <[email protected]> Signed-off-by: Aniruddh <[email protected]> Signed-off-by: Aniruddh Srivastava <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Added Slack webhook URL validation regex Signed-off-by: Aniruddh Srivastava <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Replaced wrongly formatted dummy Slack URL with properly formatted dummy Slack URL Signed-off-by: Aniruddh Srivastava <[email protected]> Signed-off-by: Aniruddh Srivastava <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Replaced more wrongly formatted dummy Slack URL with properly formatted dummy Slack URL Signed-off-by: Aniruddh Srivastava <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Replaced even more wrongly formatted dummy Slack URL with properly formatted dummy Slack URL Signed-off-by: Aniruddh Srivastava <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Replace path of mock Slack URL with `sample_slack_url` Signed-off-by: Aniruddh <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Remove slackId from domainIds Signed-off-by: Aniruddh <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Replace wrongly formatted dummy Slack URL with properly formatted dummy Slack URL Signed-off-by: Aniruddh <[email protected]> Signed-off-by: Aniruddh <[email protected]> * Add tests for wrong Slack URLs Signed-off-by: Aniruddh <[email protected]> * Add validation tests for Slack URL Signed-off-by: Aniruddh <[email protected]> * Format Signed-off-by: Aniruddh <[email protected]> * GovSlack apps can use the slack-gov.com domain Signed-off-by: Aniruddh <[email protected]> * Add validation for gov-slack.com domain Signed-off-by: Aniruddh <[email protected]> --------- Signed-off-by: danielkyalo599 <[email protected]> Signed-off-by: zhichao-aws <[email protected]> Signed-off-by: Aniruddh <[email protected]> Signed-off-by: Hailong Cui <[email protected]> Signed-off-by: Darshit Chanpura <[email protected]> Signed-off-by: yuye-aws <[email protected]> Signed-off-by: gaobinlong <[email protected]> Signed-off-by: Aniruddh Srivastava <[email protected]> Signed-off-by: Aniruddh <[email protected]> Signed-off-by: rdani <[email protected]> Signed-off-by: Peter Zhu <[email protected]> Signed-off-by: Noir <[email protected]> Signed-off-by: Aniruddh Srivastava <[email protected]> Signed-off-by: Aniruddh <[email protected]> Co-authored-by: zhichao-aws <[email protected]> Co-authored-by: danielkyalo599 <[email protected]> Co-authored-by: Hailong Cui <[email protected]> Co-authored-by: Darshit Chanpura <[email protected]> Co-authored-by: Yuye Zhu <[email protected]> Co-authored-by: gaobinlong <[email protected]> Co-authored-by: Rachana Dani <[email protected]> Co-authored-by: rdani <[email protected]> Co-authored-by: Peter Zhu <[email protected]> (cherry picked from commit 87109a0) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan
approved these changes
Aug 23, 2024
lezzago
approved these changes
Aug 23, 2024
sbcd90
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 87109a0 from #814.