Adding Max HTTP Response Size IT #901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dennis Toepker <[email protected]>
toepkerd
requested review from
xluo-aws,
gaobinlong,
Hailong-am,
SuZhou-Joe,
zhichao-aws,
yuye-aws,
zhongnansu,
sbcd90,
praveensameneni and
amsiglan
as code owners
Hailong-am
reviewed
Apr 7, 2024
| ) | ||
| Assert.assertNotNull(updateSettingsResponse) | ||
| logger.info("update settings response: $updateSettingsResponse") | ||
| Thread.sleep(1000) |
There was a problem hiding this comment.
any reason to wait for 1s
There was a problem hiding this comment.
For all comments regarding adding a 1 second wait, I took inspiration from other similar ITs, for example: https://github.com/opensearch-project/notifications/blob/main/notifications/notifications/src/test/kotlin/org/opensearch/integtest/send/SendTestMessageWithMockServerIT.kt
| """.trimIndent() | ||
| val configId = createConfigWithRequestJsonString(createRequestJsonString) | ||
| Assert.assertNotNull(configId) | ||
| Thread.sleep(1000) |
| val statusText = sendResponse.getAsJsonArray("status_list")[0].asJsonObject["delivery_status"].asJsonObject["status_text"].asString | ||
|
|
||
| // we set the max HTTP response size to 8 bytes, which means the expected string length of the response is 8 / 2 (bytes per Java char) = 4 | ||
| Assert.assertEquals(4, statusText.length) |
There was a problem hiding this comment.
how about we set max http response size to 9? how the result will look like?
There was a problem hiding this comment.
it will do an int division truncation and limit the string to 4 chars
notifications/notifications/src/test/kotlin/org/opensearch/integtest/MaxHTTPResponseSizeIT.kt
Show resolved
Hide resolved
Hailong-am
reviewed
Apr 7, 2024
Signed-off-by: Dennis Toepker <[email protected]>
Hailong-am
previously approved these changes
Apr 9, 2024
sbcd90
approved these changes
Apr 16, 2024
Hailong-am
approved these changes
Apr 16, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Apr 16, 2024
* Adding integ test for HTTP response max size setting Signed-off-by: Dennis Toepker <[email protected]> * misc build fixes Signed-off-by: Dennis Toepker <[email protected]> --------- Signed-off-by: Dennis Toepker <[email protected]> Co-authored-by: Dennis Toepker <[email protected]> (cherry picked from commit a62c920) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
amsiglan
pushed a commit
that referenced
this pull request
Apr 30, 2024
* Adding integ test for HTTP response max size setting * misc build fixes --------- (cherry picked from commit a62c920) Signed-off-by: Dennis Toepker <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Dennis Toepker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
IT for #861
Issues Resolved
See above Issue
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.