-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds webhook format check for Chime #816
Conversation
Signed-off-by: Aniruddh Srivastava <[email protected]>
Signed-off-by: Aniruddh Srivastava <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #816 +/- ##
============================================
+ Coverage 66.89% 66.93% +0.03%
- Complexity 265 267 +2
============================================
Files 39 39
Lines 1740 1742 +2
Branches 165 165
============================================
+ Hits 1164 1166 +2
Misses 453 453
Partials 123 123
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Should I add new tests for this like I did in #814 ? |
Yes, please. |
Signed-off-by: Aniruddh Srivastava <[email protected]>
Signed-off-by: Aniruddh Srivastava <[email protected]>
Signed-off-by: Aniruddh Srivastava <[email protected]>
Signed-off-by: Aniruddh Srivastava <[email protected]>
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
@Noir01 will this be backported to 2.x versions? |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/notifications/backport-2.10 2.10
# Navigate to the new working tree
pushd ../.worktrees/notifications/backport-2.10
# Create a new branch
git switch --create backport/backport-816-to-2.10
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 1163d542a6028faeb7941349ea9232f1c490a45d
# Push it to GitHub
git push --set-upstream origin backport/backport-816-to-2.10
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/notifications/backport-2.10 Then, create a pull request where the |
Description
Adds webhook format check for Chime
Issues Resolved
fixes #788
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.