Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable detekt #796

Merged
merged 2 commits into from
Oct 18, 2023
Merged

Re-enable detekt #796

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23888d0
Re-enable detekt
Noir01 Oct 16, 2023
5411cb2
Merge branch 'main' into Noir01-patch-2
Hailong-am Oct 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 7 additions & 10 deletions notifications/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,16 +38,14 @@ buildscript {
classpath "org.opensearch.gradle:build-tools:${opensearch_version}"
classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:${kotlin_version}"
classpath "org.jetbrains.kotlin:kotlin-allopen:${kotlin_version}"
// TODO: enable detekt only when snakeyaml vulnerability is fixed
// classpath "io.gitlab.arturbosch.detekt:detekt-gradle-plugin:1.17.1"
classpath "io.gitlab.arturbosch.detekt:detekt-gradle-plugin:1.23.0"
classpath "org.jacoco:org.jacoco.agent:0.8.7"
}
}

apply plugin: 'base'
apply plugin: 'jacoco'
// TODO: enable detekt only when snakeyaml vulnerability is fixed
//apply plugin: 'io.gitlab.arturbosch.detekt'
apply plugin: 'io.gitlab.arturbosch.detekt'
apply from: 'build-tools/merged-coverage.gradle'

allprojects {
Expand Down Expand Up @@ -100,12 +98,11 @@ task ktlintFormat(type: JavaExec, group: "formatting") {
jvmArgs "--add-opens=java.base/java.lang=ALL-UNNAMED"
}

// TODO: enable detekt only when snakeyaml vulnerability is fixed
//detekt {
// config = files("detekt.yml")
// buildUponDefaultConfig = true
// parallel = true
//}
detekt {
config = files("detekt.yml")
buildUponDefaultConfig = true
parallel = true
}

check.dependsOn ktlint

Expand Down
Loading