Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Fix core refactor: StreamIO from common to core.common (#707) #719

Merged
merged 2 commits into from
Jul 25, 2023

Conversation

Hailong-am
Copy link
Collaborator

@Hailong-am Hailong-am commented Jul 24, 2023

Backport fd8fe22 from #707
Backport 8efd279 from #717

@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Merging #719 (fc488cf) into 2.x (df57e31) will increase coverage by 4.25%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                2.x     #719      +/-   ##
============================================
+ Coverage     61.51%   65.77%   +4.25%     
- Complexity      114      253     +139     
============================================
  Files            73       39      -34     
  Lines          2474     1677     -797     
  Branches        266      158     -108     
============================================
- Hits           1522     1103     -419     
+ Misses          775      456     -319     
+ Partials        177      118      -59     
Flag Coverage Δ
opensearch-notifications 65.77% <ø> (+4.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...org/opensearch/notifications/NotificationPlugin.kt 97.43% <ø> (ø)
...pensearch/notifications/action/PluginBaseAction.kt 43.93% <ø> (+0.65%) ⬆️
...earch/notifications/index/ConfigIndexingActions.kt 60.82% <ø> (+4.14%) ⬆️
...opensearch/notifications/index/ConfigOperations.kt 0.00% <ø> (ø)
...pensearch/notifications/index/ConfigQueryHelper.kt 90.99% <ø> (ø)
...opensearch/notifications/index/EventQueryHelper.kt 0.00% <ø> (ø)
...rch/notifications/index/NotificationConfigIndex.kt 70.12% <ø> (+0.45%) ⬆️
.../org/opensearch/notifications/model/DocMetadata.kt 89.65% <ø> (ø)
...earch/notifications/model/NotificationConfigDoc.kt 100.00% <ø> (ø)
...notifications/model/SendTestNotificationRequest.kt 100.00% <ø> (ø)
... and 8 more

... and 35 files with indirect coverage changes

@Hailong-am
Copy link
Collaborator Author

security test failure due to docker image opensearchstaging/opensearch:2.10.0 don't have security plugin installed

@Hailong-am Hailong-am mentioned this pull request Jul 25, 2023
1 task
@Hailong-am Hailong-am merged commit 120a976 into opensearch-project:2.x Jul 25, 2023
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants