[Backport 2.5] convert empty httpEntity to {} to avoid DeliveryStatus initialization exception #660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
… exception (#648) * convert empty httpEntity to {} to avoid DeliveryStatus initialization exception Signed-off-by: Hailong Cui <[email protected]> * add integTest case for webhook empty response Signed-off-by: Hailong Cui <[email protected]> --------- Signed-off-by: Hailong Cui <[email protected]> (cherry picked from commit 94c225d)
|
|
|
This should be merged into 2.5 since it was a bug fix that was required for 2.5 |
Signed-off-by: Hailong Cui <[email protected]>
Codecov Report
@@ Coverage Diff @@
## 2.5 #660 +/- ##
============================================
+ Coverage 61.22% 61.35% +0.13%
- Complexity 113 115 +2
============================================
Files 73 73
Lines 2486 2487 +1
Branches 268 269 +1
============================================
+ Hits 1522 1526 +4
+ Misses 785 782 -3
Partials 179 179
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Hailong-am
approved these changes
Jul 28, 2023
zhichao-aws
approved these changes
Jul 28, 2023
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 94c225d from #648