Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix workflow failure on Cypress cache #603

Merged

Conversation

ansjcy
Copy link
Member

@ansjcy ansjcy commented Jan 11, 2023

Signed-off-by: Chenyang Ji [email protected]

Description

The Windows workflow for the notifications plugin has been constantly failing on the same error:

Error: .github/workflows/dashboards-notifications-test-and-build-workflow.yml (Line: 171, Col: 16):
Error: The template is not valid. .github/workflows/dashboards-notifications-test-and-build-workflow.yml (Line: 171, Col: 16): hashFiles('**/package.json') couldn't finish within [120](https://github.com/opensearch-project/dashboards-notifications/actions/runs/3879144103/jobs/6616037715#step:19:2) seconds.

Some examples:
https://github.com/opensearch-project/notifications/actions/runs/3858703629/jobs/6577511119
https://github.com/opensearch-project/notifications/actions/runs/3851206488/jobs/6562149762

After some research and testing, I think this is caused by the hashFiles expression not able to handle requested files if there are huge amount of files in the working directory (GITHUB_WORKSPACE).

Explicitly specifying the hashed file as the package.json of repo can fix the build failure.

References:
https://docs.github.com/en/actions/learn-github-actions/expressions
actions/runner#1840
actions/runner#449

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ansjcy ansjcy requested a review from a team January 11, 2023 01:55
@ansjcy ansjcy merged commit 7f5717e into opensearch-project:main Jan 11, 2023
dankyalo599 pushed a commit to dankyalo599/notifications that referenced this pull request Feb 13, 2023
Signed-off-by: Chenyang Ji <[email protected]>

Signed-off-by: Chenyang Ji <[email protected]>
Co-authored-by: Chenyang Ji <[email protected]>
Signed-off-by: danielkyalo599 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants