Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Email test for security integration test #462

Merged
merged 3 commits into from
May 23, 2022

Conversation

lezzago
Copy link
Member

@lezzago lezzago commented May 20, 2022

Signed-off-by: Ashish Agrawal [email protected]

Description

Fix Email test for security integration test

Issues Resolved

#460

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@lezzago lezzago requested a review from a team May 20, 2022 00:22
lezzago added 2 commits May 19, 2022 17:46
Signed-off-by: Ashish Agrawal <[email protected]>
Signed-off-by: Ashish Agrawal <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented May 20, 2022

Codecov Report

Merging #462 (7b5218b) into main (395d68d) will increase coverage by 0.30%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #462      +/-   ##
============================================
+ Coverage     70.71%   71.01%   +0.30%     
- Complexity      108      112       +4     
============================================
  Files           124      124              
  Lines          3923     3923              
  Branches        626      626              
============================================
+ Hits           2774     2786      +12     
+ Misses          979      961      -18     
- Partials        170      176       +6     
Flag Coverage Δ
dashboards-notifications 86.40% <ø> (ø)
opensearch-notifications 61.70% <ø> (+0.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...notifications/core/client/DestinationSmtpClient.kt 69.23% <0.00%> (+1.92%) ⬆️
...notifications/core/client/EmailMessageValidator.kt 80.00% <0.00%> (+10.00%) ⬆️
...rch/notifications/core/client/EmailMimeProvider.kt 70.00% <0.00%> (+25.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 395d68d...7b5218b. Read the comment docs.

@lezzago
Copy link
Member Author

lezzago commented May 20, 2022

The email integration test only works with localhost and not remote hosts. Created this issue to track this.

@lezzago
Copy link
Member Author

lezzago commented May 20, 2022

Security integration test passes:

./gradlew integTest-Dtests.rest.cluster=localhost:9200 -Dtests.cluster=localhost:9200 -Dtests.clustername=opensearch-integrationtest -Dhttps=true -Duser=admin -Dpassword=admin

(22-05-20 0:45:45) <130> [~/Documents/workspace/notification-sync/notifications/notifications]  
<myhost> % ./gradlew integTest -Dtests.rest.cluster=localhost:9200 -Dtests.cluster=localhost:9200 -Dtests.clustername=opensearch-integrationtest -Dhttps=true -Duser=admin -Dpassword=admin
=======================================
OpenSearch Build Hamster says Hello!
  Gradle Version        : 7.3
  OS Info               : Linux 
  JDK Version           : 11 ( JDK)
  JAVA_HOME             : Java11
  Random Testing Seed   : 574FEAF2C48C78F9
  In FIPS 140 mode      : false
=======================================

> Task :ktlint
00:45:50.873 [main] DEBUG com.pinterest.ktlint.Main - Discovered reporter with "baseline" id.
00:45:50.874 [main] DEBUG com.pinterest.ktlint.Main - Discovered reporter with "checkstyle" id.
00:45:50.875 [main] DEBUG com.pinterest.ktlint.Main - Discovered reporter with "json" id.
00:45:50.875 [main] DEBUG com.pinterest.ktlint.Main - Discovered reporter with "html" id.
00:45:50.875 [main] DEBUG com.pinterest.ktlint.Main - Discovered reporter with "plain" id.
00:45:50.875 [main] DEBUG com.pinterest.ktlint.Main - Discovered reporter with "sarif" id.
00:45:50.875 [main] DEBUG com.pinterest.ktlint.Main - Initializing "plain" reporter with {verbose=false, color=false, color_name=DARK_GRAY}
00:45:53.524 [main] DEBUG com.pinterest.ktlint.Main - 2913ms / 114 file(s) / 0 error(s)

Deprecated Gradle features were used in this build, making it incompatible with Gradle 8.0.

You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.

See https://docs.gradle.org/7.3/userguide/command_line_interface.html#sec:command_line_warnings

BUILD SUCCESSFUL in 2m 58s
34 actionable tasks: 5 executed, 29 up-to-date

@lezzago lezzago merged commit 7af4099 into opensearch-project:main May 23, 2022
@lezzago lezzago deleted the test-fix branch May 23, 2022 16:57
lezzago added a commit to lezzago/notifications that referenced this pull request Jul 5, 2022
* Fix Email test for security integration test

Signed-off-by: Ashish Agrawal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants