-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removal of NotificationEvent Request, Response and SearchResults #395
Removal of NotificationEvent Request, Response and SearchResults #395
Conversation
Codecov Report
@@ Coverage Diff @@
## main #395 +/- ##
=============================================
- Coverage 86.40% 61.17% -25.24%
- Complexity 0 81 +81
=============================================
Files 51 73 +22
Lines 1479 2421 +942
Branches 352 264 -88
=============================================
+ Hits 1278 1481 +203
- Misses 198 763 +565
- Partials 3 177 +174
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Dependency on this PR: opensearch-project/common-utils#153 |
...s/notifications/src/test/kotlin/org/opensearch/integtest/config/QueryNotificationConfigIT.kt
Outdated
Show resolved
Hide resolved
...ons/src/main/kotlin/org/opensearch/notifications/resthandler/NotificationEventRestHandler.kt
Show resolved
Hide resolved
...s/notifications/src/test/kotlin/org/opensearch/integtest/config/QueryNotificationConfigIT.kt
Outdated
Show resolved
Hide resolved
By the way, did you get a chance to locally run this with the frontend as well and just did a sanity check there? It looks like you're doing a follow-up on the SendMessage/SendTestMessage responses later so that doesn't have to work for now but just to check that everything else is fine would be good since the frontend GitHub Action is failing. Also, if you do test the frontend, I'd recommend using commit |
@aditjind Looks like there are compile errors after your recent commits. |
…elper/NotificationPluginRestHandler Signed-off-by: Jindal <[email protected]>
Signed-off-by: Jindal <[email protected]>
…lerIT Signed-off-by: Jindal <[email protected]>
Signed-off-by: Jindal <[email protected]>
Signed-off-by: Jindal <[email protected]>
Signed-off-by: Jindal <[email protected]>
Signed-off-by: Jindal <[email protected]>
Signed-off-by: Jindal <[email protected]>
Build depends on this PR: opensearch-project/common-utils#156 |
Build Passing Locally as this PR is needed: opensearch-project/common-utils#156
|
...s/notifications/src/main/kotlin/org/opensearch/notifications/send/SendMessageActionHelper.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: Jindal <[email protected]>
Description
This PR removes:
NotificationEventDocInfo
NotificationEventDoc
andNotificationEventDocInfo
NotificationEventDocTests
,NotificationEventIndexTests
,PluginActionTests
, ``Issues Resolved
Removal of code as part of: #394
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.