Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Get Channels API REST endpoint #384

Merged
merged 2 commits into from
Mar 22, 2022

Conversation

qreshi
Copy link
Contributor

@qreshi qreshi commented Mar 21, 2022

Description

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

qreshi added 2 commits March 21, 2022 08:45
…s/channels to _notifications/channels

Signed-off-by: Mohammad Qureshi <[email protected]>
@qreshi qreshi requested a review from a team March 21, 2022 18:07
@qreshi
Copy link
Contributor Author

qreshi commented Mar 21, 2022

Local build passed (also ran a local cluster for some sanity checks):

qreshi@186590ce20fd notifications % ./gradlew build
=======================================
OpenSearch Build Hamster says Hello!
  Gradle Version        : 7.3
  OS Info               : Mac OS X 10.16 (x86_64)
  JDK Version           : 14 (OpenJDK)
  JAVA_HOME             : /Library/Java/JavaVirtualMachines/jdk-14.0.1.jdk/Contents/Home
  Random Testing Seed   : 46791DBCE668ECB8
  In FIPS 140 mode      : false
=======================================

...

BUILD SUCCESSFUL in 5m 45s
55 actionable tasks: 23 executed, 32 up-to-date

Pasting the local build output since the GitHub Actions will fail since the common-utils changes are in PR alongside this one.

@qreshi qreshi merged commit 9f31061 into opensearch-project:main Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants