Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for codeowners to repo #372

Closed
wants to merge 2 commits into from
Closed

Add support for codeowners to repo #372

wants to merge 2 commits into from

Conversation

joshuali925
Copy link
Member

Signed-off-by: Joshua Li [email protected]

Description

signed #368

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

zhongnansu
zhongnansu previously approved these changes Jan 6, 2022
Signed-off-by: Joshua Li <[email protected]>
@joshuali925 joshuali925 dismissed stale reviews from davidcui1225 and zhongnansu via da0149e January 6, 2022 22:46
davidcui1225
davidcui1225 previously approved these changes Jan 6, 2022
@zhongnansu
Copy link
Member

fyi: no more enforced gpg signing for this repo

@joshuali925
Copy link
Member Author

fyi: no more enforced gpg signing for this repo

thanks, i'm merging the other one #368 then

@zhongnansu
Copy link
Member

fyi: no more enforced gpg signing for this repo

thanks, i'm merging the other one #368 then

@joshuali925 could you also take care of those 2?
#367
#366

@joshuali925 joshuali925 closed this Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants