Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend: update recipient group data modal #357

Merged
merged 2 commits into from
Oct 22, 2021
Merged

Frontend: update recipient group data modal #357

merged 2 commits into from
Oct 22, 2021

Conversation

joshuali925
Copy link
Member

Description

Update recipient group data modal for this change: opensearch-project/common-utils#83

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@joshuali925 joshuali925 self-assigned this Oct 22, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #357 (32334e6) into main (82707ff) will decrease coverage by 0.03%.
The diff coverage is 55.55%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #357      +/-   ##
==========================================
- Coverage   83.79%   83.75%   -0.04%     
==========================================
  Files          66       66              
  Lines        1882     1884       +2     
  Branches      495      495              
==========================================
+ Hits         1577     1578       +1     
- Misses        298      299       +1     
  Partials        7        7              
Flag Coverage Δ
dashboards-notifications 83.75% <55.55%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tions/public/pages/Emails/CreateRecipientGroup.tsx 81.81% <33.33%> (-1.52%) ⬇️
.../Emails/components/tables/RecipientGroupsTable.tsx 82.00% <100.00%> (+0.36%) ⬆️
...-notifications/public/pages/Emails/utils/helper.ts 95.65% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82707ff...32334e6. Read the comment docs.

Copy link
Contributor

@davidcui1225 davidcui1225 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - looks like workflow is failing though?

@joshuali925
Copy link
Member Author

LGTM - looks like workflow is failing though?

That's a known issue right now, and this PR doesn't touch backend

@joshuali925 joshuali925 merged commit 45c0836 into opensearch-project:main Oct 22, 2021
kavithacm pushed a commit to kavithacm/notifications that referenced this pull request Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants