Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed unit test for neural query after recent knn change in rescore context #927

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Fixed unit test for neural query after recent knn change in rescore context #927

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/test/java/org/opensearch/neuralsearch/query/NeuralQueryBuilderTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
import static org.opensearch.knn.index.query.KNNQueryBuilder.MIN_SCORE_FIELD;
import static org.opensearch.knn.index.query.KNNQueryBuilder.RESCORE_FIELD;
import static org.opensearch.knn.index.query.KNNQueryBuilder.RESCORE_OVERSAMPLE_FIELD;
import static org.opensearch.neuralsearch.util.TestUtils.DELTA_FOR_FLOATS_ASSERTION;
import static org.opensearch.neuralsearch.util.TestUtils.xContentBuilderToMap;
import static org.opensearch.neuralsearch.query.NeuralQueryBuilder.K_FIELD;
import static org.opensearch.neuralsearch.query.NeuralQueryBuilder.MODEL_ID_FIELD;
Expand Down Expand Up @@ -183,7 +184,11 @@ public void testFromXContent_withRescoreContext_thenBuildSuccessfully() {
assertEquals(QUERY_TEXT, neuralQueryBuilder.queryText());
assertEquals(MODEL_ID, neuralQueryBuilder.modelId());
assertEquals(K, neuralQueryBuilder.k());
assertEquals(RescoreContext.getDefault(), neuralQueryBuilder.rescoreContext());
assertEquals(
RescoreContext.getDefault().getOversampleFactor(),
neuralQueryBuilder.rescoreContext().getOversampleFactor(),
DELTA_FOR_FLOATS_ASSERTION
);
assertNull(neuralQueryBuilder.methodParameters());
}

Expand Down
1 change: 1 addition & 0 deletions src/testFixtures/java/org/opensearch/neuralsearch/util/TestUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ public class TestUtils {

public static final String RELATION_EQUAL_TO = "eq";
public static final float DELTA_FOR_SCORE_ASSERTION = 0.001f;
public static final float DELTA_FOR_FLOATS_ASSERTION = 0.001f;
public static final String RESTART_UPGRADE_OLD_CLUSTER = "tests.is_old_cluster";
public static final String BWC_VERSION = "tests.plugin_bwc_version";
public static final String NEURAL_SEARCH_BWC_PREFIX = "neuralsearch-bwc-";
Expand Down
Loading