[Backport 2.x] Remove batch_size of bulk API from tests & refactor BWC version check #873
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
opensearch-trigger-bot
bot
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
sean-zheng-amazon,
model-collapse,
zane-neo,
ylwu-amzn,
jngz-es and
vibrantvarun
as code owners
zane-neo
approved these changes
Aug 23, 2024
|
We should hold on merging this PR before the bwc issue get fixed |
martin-gaievski
force-pushed
the
backport/backport-852-to-2.x
branch
from
3e00c25 to
10bfaf5
Compare
…#852) * Remove batch_size of bulk API from tests & refactor BWC version check Signed-off-by: Liyun Xiu <[email protected]> * Update changelog Signed-off-by: Liyun Xiu <[email protected]> * Address some comments Signed-off-by: Liyun Xiu <[email protected]> * Update Changelog Signed-off-by: Liyun Xiu <[email protected]> --------- Signed-off-by: Liyun Xiu <[email protected]> (cherry picked from commit e1c3878) Signed-off-by: Martin Gaievski <[email protected]>
martin-gaievski
force-pushed
the
backport/backport-852-to-2.x
branch
from
10bfaf5 to
01fdea5
Compare
martin-gaievski
requested review from
zhichao-aws,
yuye-aws and
minalsha
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #873 +/- ##
============================================
- Coverage 80.37% 79.64% -0.73%
- Complexity 999 1112 +113
============================================
Files 78 87 +9
Lines 3419 3808 +389
Branches 580 648 +68
============================================
+ Hits 2748 3033 +285
- Misses 427 527 +100
- Partials 244 248 +4 ☔ View full report in Codecov by Sentry. |
|
CI is still failing for BWC actions, I've rebased the branch on latest 2.x. Who's going to work on this, is this @chishui? |
|
Is this PR still relevant/needed or we can close it, it's pending from Aug? |
|
@martin-gaievski sorry for the late response, just realize this is still pending, I'll work on this. |
Signed-off-by: zhichao-aws <[email protected]>
Signed-off-by: zhichao-aws <[email protected]>
zhichao-aws
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport e1c3878 from #852