-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: CI errors due to ml commons publish with JDK-21 and k-NN rename #835
Fix: CI errors due to ml commons publish with JDK-21 and k-NN rename #835
Conversation
Signed-off-by: yuye-aws <[email protected]>
Signed-off-by: yuye-aws <[email protected]>
Signed-off-by: yuye-aws <[email protected]>
Seems that all checks could pass, could you add a changelog entry and publish this PR, I can close mine |
Signed-off-by: yuye-aws <[email protected]>
Please move the change log entry to infratructure section |
Signed-off-by: yuye-aws <[email protected]>
Ack. Already changed. |
Signed-off-by: yuye-aws <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-835-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2b234f685b3f1df7bbf6db9dbb82bf9b77927a5c
# Push it to GitHub
git push --set-upstream origin backport/backport-835-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
…pensearch-project#835) * test CI error Signed-off-by: yuye-aws <[email protected]> * remove java 11 and 17 for CI workflow Signed-off-by: yuye-aws <[email protected]> * remove java 11 and 17 for CI workflow Signed-off-by: yuye-aws <[email protected]> * update changelog Signed-off-by: yuye-aws <[email protected]> * update changelog Signed-off-by: yuye-aws <[email protected]> * revert knn rename bug fix Signed-off-by: yuye-aws <[email protected]> --------- Signed-off-by: yuye-aws <[email protected]>
Description
This PR tests whether the current CI failure is due to JDK mismatch between ml-commons and neural-search: #834 (comment)
Issues Resolved
Fix CI test workflow with ml-commons errors.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.