Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Disable memory circuit breaker for integ tests #772

Merged
merged 1 commit into from
Jun 4, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
### Bug Fixes
- Total hit count fix in Hybrid Query ([756](https://github.com/opensearch-project/neural-search/pull/756))
### Infrastructure
- Disable memory circuit breaker for integ tests ([#770](https://github.com/opensearch-project/neural-search/pull/770))
### Documentation
### Maintenance
### Refactoring
2 changes: 1 addition & 1 deletion build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -396,7 +396,7 @@ testClusters.integTest {

// Increase heap size from default of 512mb to 1gb. When heap size is 512mb, our integ tests sporadically fail due
// to ml-commons memory circuit breaker exception
jvmArgs("-Xms1g", "-Xmx4g")
jvmArgs("-Xms1g", "-Xmx2g")
}

// Remote Integration Tests
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -52,11 +52,6 @@ public void setUp() throws Exception {
updateClusterSettings();
}

@Override
public boolean isUpdateClusterSettings() {
return false;
}

/**
* Using search pipelines with config for l2 norm:
* {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -93,11 +93,6 @@ public void setUp() throws Exception {
updateClusterSettings();
}

@Override
public boolean isUpdateClusterSettings() {
return false;
}

@Override
protected boolean preserveClusterUponCompletion() {
return true;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -87,11 +87,6 @@ public void setUp() throws Exception {
updateClusterSettings();
}

@Override
public boolean isUpdateClusterSettings() {
return false;
}

@Override
protected boolean preserveClusterUponCompletion() {
return true;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -89,11 +89,6 @@ public static void setUpCluster() {
instance.updateClusterSettings();
}

@Override
public boolean isUpdateClusterSettings() {
return false;
}

@Override
protected boolean preserveClusterUponCompletion() {
return true;
Expand Down
Loading