[Backport 2.x] Optimize parameter parsing in text chunking processor #754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Optimize parameter parsing in text chunking processor Signed-off-by: yuye-aws <[email protected]> * add change log Signed-off-by: yuye-aws <[email protected]> * fix unit tests in delimiter chunker Signed-off-by: yuye-aws <[email protected]> * fix unit tests in fixed token length chunker Signed-off-by: yuye-aws <[email protected]> * remove redundant Signed-off-by: yuye-aws <[email protected]> * refactor chunker parameter parser Signed-off-by: yuye-aws <[email protected]> * unit tests for chunker parameter parser Signed-off-by: yuye-aws <[email protected]> * fix comment Signed-off-by: yuye-aws <[email protected]> * spotless apply Signed-off-by: yuye-aws <[email protected]> --------- Signed-off-by: yuye-aws <[email protected]> (cherry picked from commit 038b1ec)
opensearch-trigger-bot
bot
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
sean-zheng-amazon,
model-collapse,
zane-neo,
ylwu-amzn,
jngz-es and
vibrantvarun
as code owners
zane-neo
approved these changes
May 21, 2024
|
@martin-gaievski can you help review? Thanks! |
martin-gaievski
previously approved these changes
May 21, 2024
martin-gaievski
dismissed
their stale review
some CI actions are failed, restarting them
martin-gaievski
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 038b1ec from #733