[Backport 2.13] Fix: change max chunk limit exception #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* change max chunk limit exception Signed-off-by: yuye-aws <[email protected]> * fix integration tests for two chunking algorithm Signed-off-by: yuye-aws <[email protected]> * update changelog Signed-off-by: yuye-aws <[email protected]> * add run time parameter string_tobe_chunked_count Signed-off-by: yuye-aws <[email protected]> * fix unit test for fixed token length and delimiter algorithm Signed-off-by: yuye-aws <[email protected]> * implement unit test for string to be chunked in fixed token length and delimiter algorithm Signed-off-by: yuye-aws <[email protected]> * update definition for string to be chunked parameter Signed-off-by: yuye-aws <[email protected]> * fix text chunking processor ut Signed-off-by: yuye-aws <[email protected]> * add string to be chunked count in text chunking processor Signed-off-by: yuye-aws <[email protected]> * add string to be chunked count in text chunking processor Signed-off-by: yuye-aws <[email protected]> * add more test cases for text chunking processor Signed-off-by: yuye-aws <[email protected]> * remove chunker util Signed-off-by: yuye-aws <[email protected]> * change chunk limit check in boht algorithms Signed-off-by: yuye-aws <[email protected]> * update ut for text chunking processor Signed-off-by: yuye-aws <[email protected]> * update parameter name to chunk_string_count Signed-off-by: yuye-aws <[email protected]> * run spot less apply Signed-off-by: yuye-aws <[email protected]> --------- Signed-off-by: yuye-aws <[email protected]> (cherry picked from commit 86b70e0)
opensearch-trigger-bot
bot
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
sean-zheng-amazon,
model-collapse,
zane-neo,
ylwu-amzn,
jngz-es and
vibrantvarun
as code owners
zane-neo
approved these changes
Apr 30, 2024
|
@zane-neo Dco check needs to be fixed. |
zane-neo
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 86b70e0 from #717