[Backport 2.x] Handle case with nested list of objects #623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Handle case with nested list of objects Signed-off-by: Gopala-Krishna.Char <[email protected]> * fix validateEmbeddingsFieldValues Method Signed-off-by: Gopala-Krishna.Char <[email protected]> * spotless formatting Signed-off-by: Gopala-Krishna.Char <[email protected]> * Onboard jenkins prod docker images on github actions (#483) Signed-off-by: Peter Zhu <[email protected]> Signed-off-by: Gopala-Krishna.Char <[email protected]> * Update dependency org.json:json to v20231013 (#481) Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com> Signed-off-by: Gopala-Krishna.Char <[email protected]> * [Backport main manually][bug fix] Fix async actions are left in neural_sparse query (#438) (#479) * [bug fix] Fix async actions are left in neural_sparse query (#438) * add serialization and deserialization Signed-off-by: zhichao-aws <[email protected]> * hash, equals. + UT Signed-off-by: zhichao-aws <[email protected]> * tidy Signed-off-by: zhichao-aws <[email protected]> * add test Signed-off-by: zhichao-aws <[email protected]> --------- Signed-off-by: zhichao-aws <[email protected]> (cherry picked from commit 51e6c00) * rm max_token_score Signed-off-by: zhichao-aws <[email protected]> * add changelog Signed-off-by: zhichao-aws <[email protected]> * tidy Signed-off-by: zhichao-aws <[email protected]> --------- Signed-off-by: zhichao-aws <[email protected]> Signed-off-by: Gopala-Krishna.Char <[email protected]> * Fixed exception for case when Hybrid query being wrapped into bool query (#490) * Adding null check for case when hybrid query wrapped into bool query Signed-off-by: Martin Gaievski <[email protected]> Signed-off-by: Gopala-Krishna.Char <[email protected]> * Fixed Hybrid query for cases when it's wrapped into other compound queries (#498) * Fixed nested field case Signed-off-by: Martin Gaievski <[email protected]> Signed-off-by: Gopala-Krishna.Char <[email protected]> * Added the github action to copy the attached issues label to PR. (#504) Signed-off-by: Navneet Verma <[email protected]> Signed-off-by: Gopala-Krishna.Char <[email protected]> * Added support for jdk-21 (#500) * Added support for jdk-21 Signed-off-by: Martin Gaievski <[email protected]> Signed-off-by: Gopala-Krishna.Char <[email protected]> * Add unit tests + small fixes Signed-off-by: krishy91 <[email protected]> * fix indentation Signed-off-by: krishy91 <[email protected]> * remove unused code + add 2nd level nesting test Signed-off-by: krishy91 <[email protected]> * add integration test for list of nested objects Signed-off-by: krishy91 <[email protected]> --------- Signed-off-by: Gopala-Krishna.Char <[email protected]> Signed-off-by: Peter Zhu <[email protected]> Signed-off-by: zhichao-aws <[email protected]> Signed-off-by: Martin Gaievski <[email protected]> Signed-off-by: Navneet Verma <[email protected]> Signed-off-by: krishy91 <[email protected]> Co-authored-by: Gopala-Krishna.Char <[email protected]> Co-authored-by: Peter Zhu <[email protected]> Co-authored-by: mend-for-github-com[bot] <50673670+mend-for-github-com[bot]@users.noreply.github.com> Co-authored-by: zhichao-aws <[email protected]> Co-authored-by: Martin Gaievski <[email protected]> Co-authored-by: Navneet Verma <[email protected]> (cherry picked from commit ea49d3c)
opensearch-trigger-bot
bot
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
sean-zheng-amazon,
model-collapse,
zane-neo,
ylwu-amzn,
jngz-es and
vibrantvarun
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #623 +/- ##
============================================
- Coverage 85.17% 85.14% -0.03%
- Complexity 611 616 +5
============================================
Files 48 48
Lines 1841 1858 +17
Branches 279 285 +6
============================================
+ Hits 1568 1582 +14
- Misses 145 146 +1
- Partials 128 130 +2 ☔ View full report in Codecov by Sentry. |
zane-neo
approved these changes
Mar 1, 2024
vibrantvarun
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport ea49d3c from #477