Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Varun(vibrantvarun) to list of CODEOWNERS #585

Merged
merged 5 commits into from
Feb 5, 2024
Merged

Adding Varun(vibrantvarun) to list of CODEOWNERS #585

merged 5 commits into from
Feb 5, 2024

Conversation

vibrantvarun
Copy link
Member

@vibrantvarun vibrantvarun commented Feb 2, 2024 •
edited
Loading

Description

Adding @vibrantvarun to the list of codeowners
@opensearch-project/admin

@codecov Codecov
Copy link

codecov bot commented Feb 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8b27f7a) 84.39% compared to head (c4bcd9f) 84.39%.
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##               main     #585   +/-   ##
=========================================
  Coverage     84.39%   84.39%           
  Complexity      535      535           
=========================================
  Files            40       40           
  Lines          1570     1570           
  Branches        245      245           
=========================================
  Hits           1325     1325           
  Misses          133      133           
  Partials        112      112

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vibrantvarun vibrantvarun reopened this Feb 2, 2024
@gaiksaya
Copy link
Member

gaiksaya commented Feb 2, 2024

The error is due to missing permissions. Below are the options to solve it:

  1. Add @wujunshen with maintainer access
  2. If @wujunshen does not want to be a maintainer anymore, please move them to emeritus section in maintainers.md file.

Let me know.
Thanks!

@vibrantvarun
Copy link
Member Author

vibrantvarun commented Feb 2, 2024 •
edited
Loading

Hi @gaiksaya adding @wujunshen back in codeowners.

Please give appropriate permissions to @vibrantvarun and @wujunshen.

@opensearch-project/admin

@martin-gaievski
Copy link
Member

@wujunshen I see you're not actively contributing to this repo https://github.com/opensearch-project/neural-search/graphs/contributors. Do you still want to be a maintainer? Please check error in request above, need to know your answer in order to unblock adding of new person to the list.

@vibrantvarun vibrantvarun reopened this Feb 2, 2024
@vibrantvarun vibrantvarun reopened this Feb 2, 2024
@vibrantvarun
Copy link
Member Author

Screenshot 2024-02-02 at 11 20 14 AM

@gaiksaya
Copy link
Member

gaiksaya commented Feb 2, 2024

Added @vibrantvarun with maintain access.
Thanks!

@vibrantvarun
Copy link
Member Author

@martin-gaievski I think we can merge this PR now

@vibrantvarun vibrantvarun added the backport 2.x Label will add auto workflow to backport PR to 2.x branch label Feb 5, 2024
martin-gaievski
martin-gaievski requested changes Feb 5, 2024
View reviewed changes
Copy link
Member

@martin-gaievski martin-gaievski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a response from @@wujunshen, we can move him to emeritus section in the list.

@vibrantvarun
Copy link
Member Author

ACK @martin-gaievski

@vibrantvarun vibrantvarun merged commit 8bb1bac into opensearch-project:main Feb 5, 2024
56 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 5, 2024
@vibrantvarun @github-actions
Adding Varun(vibrantvarun) to list of CODEOWNERS (#585)
3818a4e 
* Adding Varun(vibrantvarun) to list of CODEOWNERS

Signed-off-by: Varun Jain <[email protected]>

* Add wujunshen back in codeowners

Signed-off-by: Varun Jain <[email protected]>

* Adding @wujunshen in Emeritus Section

Signed-off-by: Varun Jain <[email protected]>

* Add wujunshen back in codeowners

Signed-off-by: Varun Jain <[email protected]>

* Add wujunshen back in codeowners

Signed-off-by: Varun Jain <[email protected]>

---------

Signed-off-by: Varun Jain <[email protected]>
(cherry picked from commit 8bb1bac)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Feb 5, 2024
Merged
vibrantvarun added a commit that referenced this pull request Feb 5, 2024
@opensearch-trigger-bot @vibrantvarun
Adding Varun(vibrantvarun) to list of CODEOWNERS (#585) (#587)
5d81d74 
* Adding Varun(vibrantvarun) to list of CODEOWNERS

Signed-off-by: Varun Jain <[email protected]>

* Add wujunshen back in codeowners

Signed-off-by: Varun Jain <[email protected]>

* Adding @wujunshen in Emeritus Section

Signed-off-by: Varun Jain <[email protected]>

* Add wujunshen back in codeowners

Signed-off-by: Varun Jain <[email protected]>

* Add wujunshen back in codeowners

Signed-off-by: Varun Jain <[email protected]>

---------

Signed-off-by: Varun Jain <[email protected]>
(cherry picked from commit 8bb1bac)

Co-authored-by: Varun Jain <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martin-gaievski martin-gaievski martin-gaievski approved these changes

@junqiu-lei junqiu-lei junqiu-lei approved these changes

@heemin32 heemin32 Awaiting requested review from heemin32 heemin32 is a code owner

@navneet1v navneet1v Awaiting requested review from navneet1v navneet1v is a code owner

@VijayanB VijayanB Awaiting requested review from VijayanB VijayanB is a code owner

@vamshin vamshin Awaiting requested review from vamshin vamshin is a code owner

@jmazanec15 jmazanec15 Awaiting requested review from jmazanec15 jmazanec15 is a code owner

@naveentatikonda naveentatikonda Awaiting requested review from naveentatikonda naveentatikonda is a code owner

@sean-zheng-amazon sean-zheng-amazon Awaiting requested review from sean-zheng-amazon sean-zheng-amazon is a code owner

@model-collapse model-collapse Awaiting requested review from model-collapse model-collapse is a code owner

@zane-neo zane-neo Awaiting requested review from zane-neo zane-neo is a code owner

@ylwu-amzn ylwu-amzn Awaiting requested review from ylwu-amzn

@jngz-es jngz-es Awaiting requested review from jngz-es

Assignees
No one assigned
Labels
backport 2.x Label will add auto workflow to backport PR to 2.x branch skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vibrantvarun @gaiksaya @martin-gaievski @junqiu-lei