Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: typo for sparse encoding processor factory #578

Conversation

yuye-aws
Copy link
Member

@yuye-aws yuye-aws commented Feb 1, 2024

Description

Fix typo for sparse encoding processor factory

Issues Resolved

Fix: typo for sparse encoding processor factory

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@yuye-aws
Copy link
Member Author

yuye-aws commented Feb 1, 2024

Does anyone know why Changelog Verifier gets failed?

@navneet1v
Copy link
Collaborator

@yuye-aws you have to update the changelog.md file to make sure that changelog verifier is passing.

@yuye-aws
Copy link
Member Author

yuye-aws commented Feb 5, 2024

changelog.md

Thanks, I will update the file.

Signed-off-by: yuye-aws <[email protected]>
Copy link

codecov bot commented Feb 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d298e2b) 84.39% compared to head (bfcf24d) 84.39%.
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #578   +/-   ##
=========================================
  Coverage     84.39%   84.39%           
  Complexity      535      535           
=========================================
  Files            40       40           
  Lines          1570     1570           
  Branches        245      245           
=========================================
  Hits           1325     1325           
  Misses          133      133           
  Partials        112      112           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yuye-aws
Copy link
Member Author

yuye-aws commented Feb 5, 2024

@navneet1v All tests have passed my update to the change log file. Please help review my PR, thanks!

@vibrantvarun vibrantvarun self-requested a review February 5, 2024 17:28
@martin-gaievski martin-gaievski added the backport 2.x Label will add auto workflow to backport PR to 2.x branch label Feb 8, 2024
@martin-gaievski martin-gaievski merged commit 9acad2e into opensearch-project:main Feb 8, 2024
58 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-578-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9acad2e22911537f7bb3bc498e65d2412e50e214
# Push it to GitHub
git push --set-upstream origin backport/backport-578-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-578-to-2.x.

@martin-gaievski
Copy link
Member

@yuye-aws please submit manual backport PR, corresponding CI action has failed

@yuye-aws
Copy link
Member Author

yuye-aws commented Feb 9, 2024

Sure. This is my back PR: #600

@yuye-aws yuye-aws deleted the fix/typoSparseEncodingProcessorFactory branch February 18, 2024 11:19
yuye-aws added a commit to yuye-aws/neural-search that referenced this pull request Mar 8, 2024
* typo fix for sparse encoding processor factory
---------

Signed-off-by: yuye-aws <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Label will add auto workflow to backport PR to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants