-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: typo for sparse encoding processor factory #578
Fix: typo for sparse encoding processor factory #578
Conversation
Signed-off-by: yuye-aws <[email protected]>
Does anyone know why Changelog Verifier gets failed? |
@yuye-aws you have to update the changelog.md file to make sure that changelog verifier is passing. |
Thanks, I will update the file. |
Signed-off-by: yuye-aws <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #578 +/- ##
=========================================
Coverage 84.39% 84.39%
Complexity 535 535
=========================================
Files 40 40
Lines 1570 1570
Branches 245 245
=========================================
Hits 1325 1325
Misses 133 133
Partials 112 112 ☔ View full report in Codecov by Sentry. |
@navneet1v All tests have passed my update to the change log file. Please help review my PR, thanks! |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-578-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9acad2e22911537f7bb3bc498e65d2412e50e214
# Push it to GitHub
git push --set-upstream origin backport/backport-578-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
@yuye-aws please submit manual backport PR, corresponding CI action has failed |
Sure. This is my back PR: #600 |
* typo fix for sparse encoding processor factory --------- Signed-off-by: yuye-aws <[email protected]>
Description
Fix typo for sparse encoding processor factory
Issues Resolved
Fix: typo for sparse encoding processor factory
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.