Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add validations from appsec #562

Merged
merged 10 commits into from
Jan 31, 2024

separate query validation errors; also log them

e53c0a1
Select commit
Loading
Failed to load commit list.
Merged

Add validations from appsec #562

separate query validation errors; also log them
e53c0a1
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Jan 30, 2024 in 1s

66.66% of diff hit (target 84.70%)

View this Pull Request on Codecov

66.66% of diff hit (target 84.70%)

Annotations

Check warning on line 149 in src/main/java/org/opensearch/neuralsearch/plugin/NeuralSearch.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/neuralsearch/plugin/NeuralSearch.java#L149 

Added line #L149 was not covered by tests

Check warning on line 163 in src/main/java/org/opensearch/neuralsearch/plugin/NeuralSearch.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/neuralsearch/plugin/NeuralSearch.java#L163 

Added line #L163 was not covered by tests

Check warning on line 125 in src/main/java/org/opensearch/neuralsearch/processor/rerank/context/QueryContextSourceFetcher.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/neuralsearch/processor/rerank/context/QueryContextSourceFetcher.java#L125 

Added line #L125 was not covered by tests

Check warning on line 141 in src/main/java/org/opensearch/neuralsearch/processor/rerank/context/QueryContextSourceFetcher.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/neuralsearch/processor/rerank/context/QueryContextSourceFetcher.java#L139-L141 

Added lines #L139 - L141 were not covered by tests

Check warning on line 145 in src/main/java/org/opensearch/neuralsearch/processor/rerank/context/QueryContextSourceFetcher.java

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/main/java/org/opensearch/neuralsearch/processor/rerank/context/QueryContextSourceFetcher.java#L145 

Added line #L145 was not covered by tests
View more details on Codecov