Bwc test #499
Bwc test #499
Conversation
Signed-off-by: Varun Jain <[email protected]>
Signed-off-by: Varun Jain <[email protected]>
Signed-off-by: Varun Jain <[email protected]>
Signed-off-by: Varun Jain <[email protected]>
Signed-off-by: Varun Jain <[email protected]>
Signed-off-by: Varun Jain <[email protected]>
There was a problem hiding this comment.
I'm curios did you test anything with deployed models? In ml-commons there is this feature of automatic model undeploy/deploy, problem with that is that model id changes, that was one of the reasons we deploy fresh model for each integ test. Same thing can happen when nodes or all cluster got upgraded or/and restarted
| public static final float DELTA_FOR_SCORE_ASSERTION = 0.001f; | ||
| public static final String CLIENT_TIMEOUT_VALUE = "90s"; |
There was a problem hiding this comment.
I think most of the constants that were moved here belong to exact integ test classes. In this shared util class we need to have something very generic and/or applicable to multiple tests, like NODES_BWC_CLUSTER or UPGRADED_CLUSTER.
There was a problem hiding this comment.
Some of the settings for ml-commons we're using for integ tests are not supported in earlier versions. we need be a mechanism to handle that, otherwise bwc may start fail if we add some new setting in future. Example is "plugins.ml_commons.allow_registering_model_via_url", added in 2.8
Description
[Describe what this change achieves]
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.