Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GHA to publish to maven repository #130

Merged
merged 1 commit into from
Mar 3, 2023

Conversation

VijayanB
Copy link
Member

@VijayanB VijayanB commented Mar 2, 2023

Description

Add GHA to publish to maven repository

Issues Resolved

#114

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@VijayanB VijayanB requested a review from a team March 2, 2023 02:09
@VijayanB
Copy link
Member Author

VijayanB commented Mar 2, 2023

Build failure fix is raised here #129

export SONATYPE_PASSWORD=$(aws secretsmanager get-secret-value --secret-id maven-snapshots-password --query SecretString --output text)
echo "::add-mask::$SONATYPE_USERNAME"
echo "::add-mask::$SONATYPE_PASSWORD"
./gradlew publishPluginZipPublicationToSnapshotsRepository
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Add new line

Signed-off-by: Vijayan Balasubramanian <[email protected]>
@martin-gaievski
Copy link
Member

For reference, there is one more change required in case we need to publish jars in addition to zips, this is PR for such change: opensearch-project/ml-commons#764

@VijayanB VijayanB merged commit c7b63d6 into opensearch-project:main Mar 3, 2023
@VijayanB VijayanB self-assigned this Mar 3, 2023
push:
branches:
- 'main'
- '1.*'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neural search does not have 1.* branch

@VijayanB VijayanB added the backport 2.x Label will add auto workflow to backport PR to 2.x branch label Mar 3, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 3, 2023
Signed-off-by: Vijayan Balasubramanian <[email protected]>
(cherry picked from commit c7b63d6)
VijayanB pushed a commit that referenced this pull request Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Label will add auto workflow to backport PR to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants