-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up unused validateFieldName() and use existing methods for TextEmbeddingProcessorIT #1074
Merged
heemin32
merged 1 commit into
opensearch-project:main
from
yizheliu-amazon:remove-unused-methd
Jan 8, 2025
Merged
Clean up unused validateFieldName() and use existing methods for TextEmbeddingProcessorIT #1074
heemin32
merged 1 commit into
opensearch-project:main
from
yizheliu-amazon:remove-unused-methd
Jan 8, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…EmbeddingProcessorIT Signed-off-by: Yizhe Liu <[email protected]>
yizheliu-amazon
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
sean-zheng-amazon,
model-collapse,
zane-neo,
vibrantvarun,
zhichao-aws,
yuye-aws and
minalsha
as code owners
January 8, 2025 17:26
CHANGELOG can be skipped |
junqiu-lei
approved these changes
Jan 8, 2025
heemin32
approved these changes
Jan 8, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
heemin32
added
the
backport 2.x
Label will add auto workflow to backport PR to 2.x branch
label
Jan 8, 2025
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1074-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 fea0a7f0ababf20e9eb421e311431cb49c10cfe5
# Push it to GitHub
git push --set-upstream origin backport/backport-1074-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
yizheliu-amazon
added a commit
to yizheliu-amazon/neural-search
that referenced
this pull request
Jan 8, 2025
…EmbeddingProcessorIT (opensearch-project#1074) Signed-off-by: Yizhe Liu <[email protected]>
5 tasks
yizheliu-amazon
added a commit
to yizheliu-amazon/neural-search
that referenced
this pull request
Jan 10, 2025
…EmbeddingProcessorIT (opensearch-project#1074) Signed-off-by: Yizhe Liu <[email protected]>
junqiu-lei
pushed a commit
that referenced
this pull request
Jan 10, 2025
… due to document has dot in field name (#1076) * Fix bug where document embedding fails to be generated due to document has dot in field name (#1062) * Fix bug where document embedding fails to be generated due to document has dot in field name Signed-off-by: Yizhe Liu <[email protected]> * Address comments Signed-off-by: Yizhe Liu <[email protected]> --------- Signed-off-by: Yizhe Liu <[email protected]> * Clean up unused validateFieldName() and use existing methods for TextEmbeddingProcessorIT (#1074) Signed-off-by: Yizhe Liu <[email protected]> --------- Signed-off-by: Yizhe Liu <[email protected]>
martin-gaievski
pushed a commit
that referenced
this pull request
Jan 10, 2025
…EmbeddingProcessorIT (#1074) Signed-off-by: Yizhe Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Clean up unused validateFieldName() and use existing methods
getHitCount()
andgetFirstInnerHit()
for TextEmbeddingProcessorIT to simplify test code and fix build forbackport 2.x
Related Issues
Using existing methods
getHitCount()
andgetFirstInnerHit()
may help to fix build error in #1071: https://github.com/opensearch-project/neural-search/actions/runs/12664516471/job/35292787707?pr=1071Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.