increase cluster node timeout value for time consuming test cases #1060
Conversation
Signed-off-by: will-hwang <[email protected]>
will-hwang
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
martin-gaievski,
sean-zheng-amazon,
model-collapse,
zane-neo,
vibrantvarun,
zhichao-aws,
yuye-aws and
minalsha
as code owners
| waitForGreen.addParameter("cluster_manager_timeout", "60s"); | ||
| waitForGreen.addParameter("timeout", "60s"); | ||
| waitForGreen.addParameter("cluster_manager_timeout", String.format(LOCALE, "%ds", timeoutInSeconds)); | ||
| waitForGreen.addParameter("timeout", String.format(LOCALE, "%ds", timeoutInSeconds)); |
There was a problem hiding this comment.
| waitForGreen.addParameter("timeout", String.format(LOCALE, "%ds", timeoutInSeconds)); | |
| waitForGreen.addParameter("timeout", String.format(Locale.ROOT, "%ds", timeoutInSeconds)); |
There was a problem hiding this comment.
looks like both LOCALE variable is initialized here, but both LOCALE and Local.ROOT are used in different places in the file. should we make the change in other places as well?
There was a problem hiding this comment.
If they are same, I am fine. Thanks!
heemin32
added
skip-changelog
backport 2.x
|
Can we change the target branch to main instead of 2.x? The recommended way is commit to main and backport to 2.x |
@will-hwang You need to create branch for this PR based on main branch. I've tried to simply change the base to main and GH gives me 300+ changes, so such approach is not practical. |
|
closing this PR since i've opened up a new PR into |
Description
This change introduces a refactor of the code in
BaseNeuralSearchITto enable flexible timeout setting for cluster nodes, and increases the time out value from 60s to 90s for the below test cases:testBatchIngestion_SparseEncodingProcessor_E2EFlowtestTextImageEmbeddingProcessor_E2EFlowtestSparseEncodingProcessor_E2EFlowtestSemanticSearch_E2EFlowBased on the previous PRs (link), these test cases in BWC suite frequently failed with timeout, which requires manual re-run of the CI action
Related Issues
Resolves #1035 #981
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.