Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Testing Confirmation] Confirm current testing requirements #124

Open
stephen-crawford opened this issue Feb 24, 2023 · 4 comments
Open

Comments

@stephen-crawford
Copy link

stephen-crawford commented Feb 24, 2023

As part of the discussion around implementing an organization-wide testing policy, I am visiting each repo to see what tests they currently perform. I am conducting this work on GitHub so that it is easy to reference.

Looking at the Neural Search repository, it appears there is

Repository Unit Tests Integration Tests Backwards Compatibility Tests Additional Tests Link
Neural Search
  • Certificate of Origin, Link Checker, Benchmarking Tool (in progress) #124

    I don't see any requirements for code coverage in the testing documentation. If there are any specific requirements could you respond to this issue to let me know?

    If there are any tests I missed or anything you think all repositories in OpenSearch should have for testing please respond to this issue with details.

    @navneet1v
    Copy link
    Collaborator

    We are working on adding the perf test benchmarks using OpenSearch Benchmark tool for this plugin too. Issue: #34

    Right now we don't need BWC tests, but we will be adding BWC tests soon in this repo.

    I don't see any requirements for code coverage in the testing documentation.

    Ideally we would want code coverage for this repo. but right now we have not enabled it.

    @stephen-crawford
    Copy link
    Author

    Hi @navneet1v, sorry that I overlooked those details. There are a lot of these issues some sometimes I miss a few intricacies. Thank you for following up. I will be sure to update the notes to reflect what you mentioned.

    @zelinh
    Copy link
    Member

    zelinh commented Jun 26, 2023

    Created a new issue to keep track of the BWC tests #202

    @martin-gaievski
    Copy link
    Member

    martin-gaievski commented Aug 7, 2024

    @stephen-crawford is there any required part that is missing for neural-search repo, or we can close this issue?

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    No branches or pull requests

    4 participants