Skip to content

Commit

Permalink
Address Heemin's comments
Browse files Browse the repository at this point in the history
Signed-off-by: Martin Gaievski <[email protected]>
  • Loading branch information
martin-gaievski committed Dec 29, 2023
1 parent 6e3264d commit 7ea7d90
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,12 @@

package org.opensearch.neuralsearch.query;

import static java.util.Locale.ROOT;

import java.io.IOException;
import java.util.ArrayList;
import java.util.Collections;
import java.util.HashMap;
import java.util.List;
import java.util.Locale;
import java.util.Map;
import java.util.Objects;

Expand Down Expand Up @@ -128,7 +127,7 @@ public float[] hybridScores() throws IOException {
.orElseThrow(
() -> new IllegalStateException(
String.format(

Check warning on line 129 in src/main/java/org/opensearch/neuralsearch/query/HybridQueryScorer.java

View check run for this annotation

Codecov / codecov/patch

src/main/java/org/opensearch/neuralsearch/query/HybridQueryScorer.java#L128-L129

Added lines #L128 - L129 were not covered by tests
ROOT,
Locale.ROOT,
"cannot set score for one of hybrid search subquery [%s] and document [%d]",
query.toString(),
scorer.docID()

Check warning on line 133 in src/main/java/org/opensearch/neuralsearch/query/HybridQueryScorer.java

View check run for this annotation

Codecov / codecov/patch

src/main/java/org/opensearch/neuralsearch/query/HybridQueryScorer.java#L132-L133

Added lines #L132 - L133 were not covered by tests
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ public void testComplexQuery_whenMultipleSubqueries_thenSuccessful() {
}

/**
* Tests complex query with multiple nested sub-queries, where soem sub-queries are same
* Tests complex query with multiple nested sub-queries, where some sub-queries are same
* {
* "query": {
* "hybrid": {
Expand Down

0 comments on commit 7ea7d90

Please sign in to comment.