Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix model meta API and add update model group UTs #918

Conversation

rbhavna
Copy link
Collaborator

@rbhavna rbhavna commented May 25, 2023

Description

fix model meta API and add update model group UTs

Issues Resolved

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Merging #918 (4eb649f) into model-access-control-dev (8f89257) will increase coverage by 1.28%.
The diff coverage is 47.65%.

@@                      Coverage Diff                       @@
##             model-access-control-dev     #918      +/-   ##
==============================================================
+ Coverage                       70.81%   72.09%   +1.28%     
- Complexity                       1648     1704      +56     
==============================================================
  Files                             149      149              
  Lines                            7460     7516      +56     
  Branches                          743      746       +3     
==============================================================
+ Hits                             5283     5419     +136     
+ Misses                           1891     1794      -97     
- Partials                          286      303      +17     
Flag Coverage Δ
ml-commons 72.09% <47.65%> (+1.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...h/ml/action/models/DeleteModelTransportAction.java 8.23% <0.00%> (ø)
...arch/ml/action/models/GetModelTransportAction.java 14.89% <0.00%> (ø)
...h/ml/action/upload_chunk/MLModelChunkUploader.java 19.83% <0.00%> (-0.51%) ⬇️
...opensearch/ml/helper/ModelAccessControlHelper.java 8.25% <0.00%> (ø)
...rithms/metrics_correlation/MetricsCorrelation.java 36.07% <6.12%> (-23.65%) ⬇️
...n/model_group/SearchModelGroupTransportAction.java 68.18% <50.00%> (+40.18%) ⬆️
...n/model_group/TransportUpdateModelGroupAction.java 86.81% <75.00%> (+77.03%) ⬆️
...n/java/org/opensearch/ml/model/MLModelManager.java 74.26% <75.00%> (-1.24%) ⬇️
.../opensearch/ml/action/handler/MLSearchHandler.java 85.13% <80.00%> (+77.02%) ⬆️
...h/ml/action/models/SearchModelTransportAction.java 100.00% <100.00%> (+33.33%) ⬆️
... and 1 more

... and 1 file with indirect coverage changes

@rbhavna rbhavna changed the title Model access control dev fix model meta API and add update model group UTs May 25, 2023
@rbhavna rbhavna merged commit b33dcc0 into opensearch-project:model-access-control-dev May 25, 2023
b4sjoo pushed a commit to b4sjoo/ml-commons that referenced this pull request May 30, 2023
…#918)

* fix model meta API and add update model group UTs

Signed-off-by: Bhavana Ramaram <[email protected]>
b4sjoo pushed a commit to b4sjoo/ml-commons that referenced this pull request May 30, 2023
…#918)

* fix model meta API and add update model group UTs

Signed-off-by: Bhavana Ramaram <[email protected]>
Signed-off-by: Sicheng Song <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants