Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename model meta/chunk API #827

Merged
merged 1 commit into from
Mar 27, 2023
Merged

Conversation

ylwu-amzn
Copy link
Collaborator

Description

Rename model meta/chunk API

Issues Resolved

#823

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ylwu-amzn ylwu-amzn requested a review from a team March 25, 2023 01:28
@codecov-commenter
Copy link

Codecov Report

Merging #827 (77e9802) into 2.x (158d445) will decrease coverage by 0.01%.
The diff coverage is 87.67%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff              @@
##                2.x     #827      +/-   ##
============================================
- Coverage     84.84%   84.84%   -0.01%     
+ Complexity     1626     1624       -2     
============================================
  Files           135      134       -1     
  Lines          6059     6057       -2     
  Branches        592      592              
============================================
- Hits           5141     5139       -2     
  Misses          663      663              
  Partials        255      255              
Flag Coverage Δ
ml-commons 84.84% <87.67%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...upload_chunk/TransportRegisterModelMetaAction.java 80.00% <80.00%> (ø)
...n/java/org/opensearch/ml/model/MLModelManager.java 79.67% <86.36%> (+0.75%) ⬆️
...rg/opensearch/ml/plugin/MachineLearningPlugin.java 98.82% <100.00%> (-0.02%) ⬇️
...nsearch/ml/rest/RestMLRegisterModelMetaAction.java 100.00% <100.00%> (ø)
...ensearch/ml/rest/RestMLUploadModelChunkAction.java 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ylwu-amzn ylwu-amzn merged commit bf662e3 into opensearch-project:2.x Mar 27, 2023
ylwu-amzn added a commit to ylwu-amzn/ml-commons that referenced this pull request Mar 27, 2023
ylwu-amzn added a commit that referenced this pull request Mar 27, 2023
ylwu-amzn added a commit to ylwu-amzn/ml-commons that referenced this pull request Mar 28, 2023
ylwu-amzn added a commit to ylwu-amzn/ml-commons that referenced this pull request Mar 28, 2023
ylwu-amzn added a commit that referenced this pull request Mar 28, 2023
* rename model meta/chunk API (#827)

Signed-off-by: Yaliang Wu <[email protected]>

* Change the ziputil dependency to fix a potential security concern (#824)

Signed-off-by: Yaliang Wu <[email protected]>

* add text docs ML input (#830)

Signed-off-by: Yaliang Wu <[email protected]>

---------

Signed-off-by: Yaliang Wu <[email protected]>
Co-authored-by: Sicheng Song <[email protected]>
rbhavna pushed a commit to rbhavna/ml-commons that referenced this pull request May 19, 2023
…roject#837)

* rename model meta/chunk API (opensearch-project#827)

Signed-off-by: Yaliang Wu <[email protected]>

* Change the ziputil dependency to fix a potential security concern (opensearch-project#824)

Signed-off-by: Yaliang Wu <[email protected]>

* add text docs ML input (opensearch-project#830)

Signed-off-by: Yaliang Wu <[email protected]>

---------

Signed-off-by: Yaliang Wu <[email protected]>
Co-authored-by: Sicheng Song <[email protected]>
zane-neo pushed a commit that referenced this pull request May 23, 2023
* Backport changes to model-access-control feature branch (#837)

* rename model meta/chunk API (#827)

Signed-off-by: Yaliang Wu <[email protected]>

* Change the ziputil dependency to fix a potential security concern (#824)

Signed-off-by: Yaliang Wu <[email protected]>

* add text docs ML input (#830)

Signed-off-by: Yaliang Wu <[email protected]>

---------

Signed-off-by: Yaliang Wu <[email protected]>
Co-authored-by: Sicheng Song <[email protected]>

* add model group (#840)

* add model group

Signed-off-by: Yaliang Wu <[email protected]>

* rename create model group as register model group

Signed-off-by: Yaliang Wu <[email protected]>

* fix class name in build.gradle

Signed-off-by: Yaliang Wu <[email protected]>

* remove unused code; stash thread context

Signed-off-by: Yaliang Wu <[email protected]>

* exclude class for low coverage

Signed-off-by: Yaliang Wu <[email protected]>

---------

Signed-off-by: Yaliang Wu <[email protected]>

* access validation for register/update model-group, register/get/delete/deploy/predict model

Signed-off-by: Bhavana Ramaram <[email protected]>

* changes to security utils and register/search model group

Signed-off-by: Bhavana Ramaram <[email protected]>

* update last_updated_time in model group when new version added

Signed-off-by: Bhavana Ramaram <[email protected]>

* fix undeploy model action

Signed-off-by: Bhavana Ramaram <[email protected]>

* fix format violations

Signed-off-by: Bhavana Ramaram <[email protected]>

* rebased to 2.x and prediction/search API fix

Signed-off-by: Bhavana Ramaram <[email protected]>

* fix rebase conflicts

Signed-off-by: Bhavana Ramaram <[email protected]>

* new delete model group API

Signed-off-by: Bhavana Ramaram <[email protected]>

* fix formal violations

Signed-off-by: Bhavana Ramaram <[email protected]>

---------

Signed-off-by: Yaliang Wu <[email protected]>
Signed-off-by: Bhavana Ramaram <[email protected]>
Co-authored-by: Yaliang Wu <[email protected]>
Co-authored-by: Sicheng Song <[email protected]>
b4sjoo added a commit to b4sjoo/ml-commons that referenced this pull request May 30, 2023
* Backport changes to model-access-control feature branch (opensearch-project#837)

* rename model meta/chunk API (opensearch-project#827)

Signed-off-by: Yaliang Wu <[email protected]>

* Change the ziputil dependency to fix a potential security concern (opensearch-project#824)

Signed-off-by: Yaliang Wu <[email protected]>

* add text docs ML input (opensearch-project#830)

Signed-off-by: Yaliang Wu <[email protected]>

---------

Signed-off-by: Yaliang Wu <[email protected]>
Co-authored-by: Sicheng Song <[email protected]>

* add model group (opensearch-project#840)

* add model group

Signed-off-by: Yaliang Wu <[email protected]>

* rename create model group as register model group

Signed-off-by: Yaliang Wu <[email protected]>

* fix class name in build.gradle

Signed-off-by: Yaliang Wu <[email protected]>

* remove unused code; stash thread context

Signed-off-by: Yaliang Wu <[email protected]>

* exclude class for low coverage

Signed-off-by: Yaliang Wu <[email protected]>

---------

Signed-off-by: Yaliang Wu <[email protected]>

* access validation for register/update model-group, register/get/delete/deploy/predict model

Signed-off-by: Bhavana Ramaram <[email protected]>

* changes to security utils and register/search model group

Signed-off-by: Bhavana Ramaram <[email protected]>

* update last_updated_time in model group when new version added

Signed-off-by: Bhavana Ramaram <[email protected]>

* fix undeploy model action

Signed-off-by: Bhavana Ramaram <[email protected]>

* fix format violations

Signed-off-by: Bhavana Ramaram <[email protected]>

* rebased to 2.x and prediction/search API fix

Signed-off-by: Bhavana Ramaram <[email protected]>

* fix rebase conflicts

Signed-off-by: Bhavana Ramaram <[email protected]>

* new delete model group API

Signed-off-by: Bhavana Ramaram <[email protected]>

* fix formal violations

Signed-off-by: Bhavana Ramaram <[email protected]>

---------

Signed-off-by: Yaliang Wu <[email protected]>
Signed-off-by: Bhavana Ramaram <[email protected]>
Co-authored-by: Yaliang Wu <[email protected]>
Co-authored-by: Sicheng Song <[email protected]>
b4sjoo added a commit to b4sjoo/ml-commons that referenced this pull request May 30, 2023
* Backport changes to model-access-control feature branch (opensearch-project#837)

* rename model meta/chunk API (opensearch-project#827)

Signed-off-by: Yaliang Wu <[email protected]>

* Change the ziputil dependency to fix a potential security concern (opensearch-project#824)

Signed-off-by: Yaliang Wu <[email protected]>

* add text docs ML input (opensearch-project#830)

Signed-off-by: Yaliang Wu <[email protected]>

---------

Signed-off-by: Yaliang Wu <[email protected]>
Co-authored-by: Sicheng Song <[email protected]>

* add model group (opensearch-project#840)

* add model group

Signed-off-by: Yaliang Wu <[email protected]>

* rename create model group as register model group

Signed-off-by: Yaliang Wu <[email protected]>

* fix class name in build.gradle

Signed-off-by: Yaliang Wu <[email protected]>

* remove unused code; stash thread context

Signed-off-by: Yaliang Wu <[email protected]>

* exclude class for low coverage

Signed-off-by: Yaliang Wu <[email protected]>

---------

Signed-off-by: Yaliang Wu <[email protected]>

* access validation for register/update model-group, register/get/delete/deploy/predict model

Signed-off-by: Bhavana Ramaram <[email protected]>

* changes to security utils and register/search model group

Signed-off-by: Bhavana Ramaram <[email protected]>

* update last_updated_time in model group when new version added

Signed-off-by: Bhavana Ramaram <[email protected]>

* fix undeploy model action

Signed-off-by: Bhavana Ramaram <[email protected]>

* fix format violations

Signed-off-by: Bhavana Ramaram <[email protected]>

* rebased to 2.x and prediction/search API fix

Signed-off-by: Bhavana Ramaram <[email protected]>

* fix rebase conflicts

Signed-off-by: Bhavana Ramaram <[email protected]>

* new delete model group API

Signed-off-by: Bhavana Ramaram <[email protected]>

* fix formal violations

Signed-off-by: Bhavana Ramaram <[email protected]>

---------

Signed-off-by: Yaliang Wu <[email protected]>
Signed-off-by: Bhavana Ramaram <[email protected]>
Co-authored-by: Yaliang Wu <[email protected]>
Co-authored-by: Sicheng Song <[email protected]>
Signed-off-by: Sicheng Song <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants