Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

publish snapshots to maven via GHA #743

Closed
wants to merge 1 commit into from
Closed

publish snapshots to maven via GHA #743

wants to merge 1 commit into from

Conversation

Zhangxunmt
Copy link
Collaborator

@Zhangxunmt Zhangxunmt commented Feb 22, 2023 •
edited by gaiksaya
Loading

Description

Publish snapshots to maven via GHA

Issues Resolved

[#734 ]#734

Tests

find plugin/snapshots | sort
plugin/snapshots
plugin/snapshots/org
plugin/snapshots/org/opensearch
plugin/snapshots/org/opensearch/plugin
plugin/snapshots/org/opensearch/plugin/opensearch-ml-plugin
plugin/snapshots/org/opensearch/plugin/opensearch-ml-plugin/2.6.0.0-SNAPSHOT
plugin/snapshots/org/opensearch/plugin/opensearch-ml-plugin/2.6.0.0-SNAPSHOT/maven-metadata.xml
plugin/snapshots/org/opensearch/plugin/opensearch-ml-plugin/2.6.0.0-SNAPSHOT/maven-metadata.xml.md5
plugin/snapshots/org/opensearch/plugin/opensearch-ml-plugin/2.6.0.0-SNAPSHOT/maven-metadata.xml.sha1
plugin/snapshots/org/opensearch/plugin/opensearch-ml-plugin/2.6.0.0-SNAPSHOT/maven-metadata.xml.sha256
plugin/snapshots/org/opensearch/plugin/opensearch-ml-plugin/2.6.0.0-SNAPSHOT/maven-metadata.xml.sha512
plugin/snapshots/org/opensearch/plugin/opensearch-ml-plugin/2.6.0.0-SNAPSHOT/opensearch-ml-plugin-2.6.0.0-20230222.232524-1.pom
plugin/snapshots/org/opensearch/plugin/opensearch-ml-plugin/2.6.0.0-SNAPSHOT/opensearch-ml-plugin-2.6.0.0-20230222.232524-1.pom.md5
plugin/snapshots/org/opensearch/plugin/opensearch-ml-plugin/2.6.0.0-SNAPSHOT/opensearch-ml-plugin-2.6.0.0-20230222.232524-1.pom.sha1
plugin/snapshots/org/opensearch/plugin/opensearch-ml-plugin/2.6.0.0-SNAPSHOT/opensearch-ml-plugin-2.6.0.0-20230222.232524-1.pom.sha256
plugin/snapshots/org/opensearch/plugin/opensearch-ml-plugin/2.6.0.0-SNAPSHOT/opensearch-ml-plugin-2.6.0.0-20230222.232524-1.pom.sha512
plugin/snapshots/org/opensearch/plugin/opensearch-ml-plugin/2.6.0.0-SNAPSHOT/opensearch-ml-plugin-2.6.0.0-20230222.232524-1.zip
plugin/snapshots/org/opensearch/plugin/opensearch-ml-plugin/2.6.0.0-SNAPSHOT/opensearch-ml-plugin-2.6.0.0-20230222.232524-1.zip.md5
plugin/snapshots/org/opensearch/plugin/opensearch-ml-plugin/2.6.0.0-SNAPSHOT/opensearch-ml-plugin-2.6.0.0-20230222.232524-1.zip.sha1
plugin/snapshots/org/opensearch/plugin/opensearch-ml-plugin/2.6.0.0-SNAPSHOT/opensearch-ml-plugin-2.6.0.0-20230222.232524-1.zip.sha256
plugin/snapshots/org/opensearch/plugin/opensearch-ml-plugin/2.6.0.0-SNAPSHOT/opensearch-ml-plugin-2.6.0.0-20230222.232524-1.zip.sha512
plugin/snapshots/org/opensearch/plugin/opensearch-ml-plugin/maven-metadata.xml
plugin/snapshots/org/opensearch/plugin/opensearch-ml-plugin/maven-metadata.xml.md5
plugin/snapshots/org/opensearch/plugin/opensearch-ml-plugin/maven-metadata.xml.sha1
plugin/snapshots/org/opensearch/plugin/opensearch-ml-plugin/maven-metadata.xml.sha256
plugin/snapshots/org/opensearch/plugin/opensearch-ml-plugin/maven-metadata.xml.sha512

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@Zhangxunmt Zhangxunmt requested review from a team and gaiksaya February 22, 2023 23:37
@codecov-commenter
Copy link

codecov-commenter commented Feb 23, 2023 •
edited
Loading

Codecov Report

Merging #743 (0f69bc3) into 2.x (c747e50) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff            @@
##                2.x     #743   +/-   ##
=========================================
  Coverage     84.39%   84.39%           
  Complexity     1591     1591           
=========================================
  Files           135      135           
  Lines          5935     5935           
  Branches        560      560           
=========================================
  Hits           5009     5009           
  Misses          690      690           
  Partials        236      236
Flag Coverage Δ
ml-commons 84.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

ylwu-amzn
ylwu-amzn reviewed Feb 23, 2023
View reviewed changes
.github/workflows/maven-publish.yml Outdated
export SONATYPE_PASSWORD=$(aws secretsmanager get-secret-value --secret-id maven-snapshots-password --query SecretString --output text)
echo "::add-mask::$SONATYPE_USERNAME"
echo "::add-mask::$SONATYPE_PASSWORD"
./gradlew publishPluginZipPublicationToSnapshotsRepository
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this also publish ml-commons client jar to maven?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it won't. If want to publish jars to according task needs to be called. This task is only for publishing zips and associated poms. You can call multiple tasks so if we want jars to publish just add it after this task

gaiksaya
gaiksaya reviewed Feb 23, 2023
View reviewed changes
.github/workflows/maven-publish.yml Outdated
Comment on lines 16 to 18
matrix:
jdk: [17]
platform: ["ubuntu-latest"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just 1 value so you can remove the entire matrix block

update 2.6 release note
2573b4c 
Signed-off-by: Xun Zhang <[email protected]>
@Zhangxunmt Zhangxunmt closed this Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaiksaya gaiksaya gaiksaya left review comments

@ylwu-amzn ylwu-amzn ylwu-amzn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Zhangxunmt @codecov-commenter @ylwu-amzn @gaiksaya