Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds preset contentRegistry for IngestProcessors #3281

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Adds preset contentRegistry for IngestProcessors #3281

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
67c562a
add preset xContentRegistry to ingestProcessors for custom parametize…
brianf-aws Dec 16, 2024
30316f9
Adds UT for proving models depend on xContentRegistry for prediction
brianf-aws Dec 17, 2024
f9caf1b
apply spotless
brianf-aws Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion plugin/src/main/java/org/opensearch/ml/plugin/MachineLearningPlugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1062,10 +1062,12 @@ public void loadExtensions(ExtensionLoader loader) {
@Override
public Map<String, org.opensearch.ingest.Processor.Factory> getProcessors(org.opensearch.ingest.Processor.Parameters parameters) {
Map<String, org.opensearch.ingest.Processor.Factory> processors = new HashMap<>();
NamedXContentRegistry contentRegistry = new NamedXContentRegistry(getNamedXContent());

processors
.put(
MLInferenceIngestProcessor.TYPE,
new MLInferenceIngestProcessor.Factory(parameters.scriptService, parameters.client, xContentRegistry)
new MLInferenceIngestProcessor.Factory(parameters.scriptService, parameters.client, contentRegistry)
);
return Collections.unmodifiableMap(processors);
}
Expand Down
55 changes: 55 additions & 0 deletions plugin/src/test/java/org/opensearch/ml/processor/MLInferenceIngestProcessorTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
import org.opensearch.core.action.ActionListener;
import org.opensearch.core.xcontent.NamedXContentRegistry;
import org.opensearch.ingest.IngestDocument;
import org.opensearch.ml.common.FunctionName;
import org.opensearch.ml.common.dataset.remote.RemoteInferenceInputDataSet;
import org.opensearch.ml.common.input.MLInput;
import org.opensearch.ml.common.output.model.MLResultDataType;
Expand Down Expand Up @@ -138,6 +139,60 @@ public void testExecute_Exception() throws Exception {

}

/**
* Models that use the parameters field need to have a valid NamedXContentRegistry object to create valid MLInputs. For example
* <pre>
* PUT /_plugins/_ml/_predict/text_embedding/model_id
* {
* "parameters": {
* "content_type" : "query"
* },
* "text_docs" : ["what day is it today?"],
* "target_response" : ["sentence_embedding"]
* }
* </pre>
* These types of models like Local Asymmetric embedding models use the parameters field.
* And as such we need to test that having the contentRegistry throws an exception as it can not
* properly create a valid MLInput to perform prediction
*
* @implNote If you check the stack trace of the test you will see it tells you that it's a direct consequence of xContentRegistry being null
*/
public void testExecute_xContentRegistryNullWithLocalModel_throwsException() throws Exception {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't we add another test for success case with Asymmetric model?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes its possible but that would involve hosting the model zip somewhere so we can test that it makes embeddings.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we take some idea from here: https://github.com/opensearch-project/ml-commons/pull/2123/files#diff-cd8365f3263802b111604d62b751e5264a2e51df44b46b9fb650ca001466328a

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! I didn't realize the community user did that, I can definitely use that thanks!

// Set the registry to null and reset after exiting the test
xContentRegistry = null;

String localModelInput =
"{ \"text_docs\": [\"What day is it today?\"],\"target_response\": [\"sentence_embedding\"], \"parameters\": { \"contentType\" : \"query\"} }";

MLInferenceIngestProcessor processor = createMLInferenceProcessor(
"local_model_id",
null,
null,
null,
false,
FunctionName.TEXT_EMBEDDING.toString(),
false,
false,
false,
localModelInput
);
try {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

// Act & Assert: Verify NullPointerException and its message
    NullPointerException exception = assertThrows(
        NullPointerException.class,
        () -> processor.execute(ingestDocument, handler),
        "Expected NullPointerException due to null xContentRegistry"
    );

    assertTrue(exception.getMessage().contains("Cannot invoke"),
               "Exception message should indicate a failure due to null mlInput");

What do you think about this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this, but the problem is that the exception is passed by the handler its not done by the method itself. So this wouldn't be possible thats the reason why this class and more specifically this method has a catch to make sure that an exception is not possible. i.e. the handler passes an exception only.

String npeMessage =
"Cannot invoke \"org.opensearch.ml.common.input.MLInput.setAlgorithm(org.opensearch.ml.common.FunctionName)\" because \"mlInput\" is null";

processor.execute(ingestDocument, handler);
verify(handler)
.accept(
isNull(),
argThat(exception -> exception instanceof NullPointerException && exception.getMessage().equals(npeMessage))
);
} catch (Exception e) {
assertEquals("this catch block should not get executed.", e.getMessage());
}
// reset to mocked object
xContentRegistry = mock(NamedXContentRegistry.class);
}

/**
* test nested object document with array of Map<String,String>
*/
Expand Down
Loading