[FEATURE]Improve test coverage for RemoteModel.java

[akolarkunnu]

Description

Added new tests for missing coverage. Mainly coverage was missing for catching exceptions in the methods initModel() and asyncPredict(). Also renamed some tests to match with testing methods.

Related Issues

Resolves #1382

Check List

• [ X] New functionality includes testing.
• New functionality has been documented.
• API changes companion pull request created.
• [X ] Commits are signed per the DCO using --signoff.
• Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[pyek-bot]

Thanks for the contribution! Appreciate it. Can you share a coverage report similar to the one in issue to see if it actual covers those exceptions?

[akolarkunnu]

Thanks for the contribution! Appreciate it. Can you share a coverage report similar to the one in issue to see if it actual covers those exceptions?

I was expecting that code coverage report generation is part of CI, similar to other projects, eg: OpenSearch core, Security, etc. I verified the coverage by putting explicit traces in each exception blocks. Can you please share, how can I run the coverage tool and share the report links here?

[pyek-bot]

Thanks for the contribution! Appreciate it. Can you share a coverage report similar to the one in issue to see if it actual covers those exceptions?

I was expecting that code coverage report generation is part of CI, similar to other projects, eg: OpenSearch core, Security, etc. I verified the coverage by putting explicit traces in each exception blocks. Can you please share, how can I run the coverage tool and share the report links here?

• Run the jacocoTestReport gradle task for the particular package (ml-algorithms)
• Run python3 -m http.server 3000
• Open localhost:3000 on your browser
• Navigate to the ml-algorithms/build/reports/jacoco/test/html
• Open your file and check coverage

It will be locally available for you, you can just verify if those lines are hit and maybe share a screenshot. Changes look good to me!

Let me know if this helps!

[akolarkunnu]

Thanks for the contribution! Appreciate it. Can you share a coverage report similar to the one in issue to see if it actual covers those exceptions?

I was expecting that code coverage report generation is part of CI, similar to other projects, eg: OpenSearch core, Security, etc. I verified the coverage by putting explicit traces in each exception blocks. Can you please share, how can I run the coverage tool and share the report links here?

• Run the jacocoTestReport gradle task for the particular package (ml-algorithms)
• Run python3 -m http.server 3000
• Open localhost:3000 on your browser
• Navigate to the ml-algorithms/build/reports/jacoco/test/html
• Open your file and check coverage

It will be locally available for you, you can just verify if those lines are hit and maybe share a screenshot. Changes look good to me!

Let me know if this helps!

Yes this helped. All exceptions were covered, but below line was not covered, so added one more test case to cover that:

actionType = ((RemoteInferenceInputDataSet) mlInput.getInputDataset()).getActionType();

Now it is 100% branch and line, please see the screenshots.

[pyek-bot]

Looks good to me! Thank you!

[ylwu-amzn]

Thanks @akolarkunnu. can you run ./gradlew spotlessApply to format code ? I see such error in CI

* What went wrong:
Execution failed for task ':opensearch-ml-algorithms:spotlessJavaCheck'.

> The following files had format violations:
      src\test\java\org\opensearch\ml\engine\algorithms\remote\RemoteModelTest.java
Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.
          @@ -14,8 +14,8 @@
           import�static�org.mockito.Mockito.when;
           
           import�java.util.Arrays;

          +import�java.util.Collections;
           import�java.util.Map;
You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.
          -import�java.util.Collections;
           
           import�org.junit.Assert;
           import�org.junit.Before;
  Run 'gradlew.bat :opensearch-ml-algorithms:spotlessApply' to fix these violations.

[akolarkunnu]

Thanks @akolarkunnu. can you run ./gradlew spotlessApply to format code ? I see such error in CI

* What went wrong:
Execution failed for task ':opensearch-ml-algorithms:spotlessJavaCheck'.

> The following files had format violations:
      src\test\java\org\opensearch\ml\engine\algorithms\remote\RemoteModelTest.java
Deprecated Gradle features were used in this build, making it incompatible with Gradle 9.0.
          @@ -14,8 +14,8 @@
           import�static�org.mockito.Mockito.when;
           
           import�java.util.Arrays;

          +import�java.util.Collections;
           import�java.util.Map;
You can use '--warning-mode all' to show the individual deprecation warnings and determine if they come from your own scripts or plugins.
          -import�java.util.Collections;
           
           import�org.junit.Assert;
           import�org.junit.Before;
  Run 'gradlew.bat :opensearch-ml-algorithms:spotlessApply' to fix these violations.

yes, I forgot to run it this time. Ran it and updated.

[akolarkunnu]

Can any reviewers please review this?