Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out remote model auto redeployment #2976

Conversation

zane-neo
Copy link
Collaborator

@zane-neo zane-neo commented Sep 23, 2024

Description

Currently, ml-commons supports remote model auto deployment when first prediction request comes, so in MLModelAutoRedeplyer remote model auto redeployment can be filtered out.

Related Issues

NA

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dhrubo-os
Copy link
Collaborator

Apply spotless

Signed-off-by: zane-neo <[email protected]>
@zane-neo zane-neo temporarily deployed to ml-commons-cicd-env September 25, 2024 08:37 — with GitHub Actions Inactive
@zane-neo zane-neo temporarily deployed to ml-commons-cicd-env September 25, 2024 08:37 — with GitHub Actions Inactive
@zane-neo zane-neo temporarily deployed to ml-commons-cicd-env September 25, 2024 09:35 — with GitHub Actions Inactive
@ylwu-amzn ylwu-amzn merged commit e36e58f into opensearch-project:main Oct 7, 2024
6 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 7, 2024
* Filter out remote model auto redeployment

Signed-off-by: zane-neo <[email protected]>

* format code

Signed-off-by: zane-neo <[email protected]>

---------

Signed-off-by: zane-neo <[email protected]>
(cherry picked from commit e36e58f)
ylwu-amzn pushed a commit that referenced this pull request Oct 7, 2024
* Filter out remote model auto redeployment

Signed-off-by: zane-neo <[email protected]>

* format code

Signed-off-by: zane-neo <[email protected]>

---------

Signed-off-by: zane-neo <[email protected]>
(cherry picked from commit e36e58f)

Co-authored-by: zane-neo <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 7, 2024
* Filter out remote model auto redeployment

Signed-off-by: zane-neo <[email protected]>

* format code

Signed-off-by: zane-neo <[email protected]>

---------

Signed-off-by: zane-neo <[email protected]>
(cherry picked from commit e36e58f)
ylwu-amzn pushed a commit that referenced this pull request Oct 7, 2024
* Filter out remote model auto redeployment

Signed-off-by: zane-neo <[email protected]>

* format code

Signed-off-by: zane-neo <[email protected]>

---------

Signed-off-by: zane-neo <[email protected]>
(cherry picked from commit e36e58f)

Co-authored-by: zane-neo <[email protected]>
zane-neo added a commit to zane-neo/ml-commons that referenced this pull request Oct 14, 2024
…e and algorithm in query models

Signed-off-by: zane-neo <[email protected]>
zane-neo added a commit to zane-neo/ml-commons that referenced this pull request Oct 14, 2024
…e and algorithm in query models

Signed-off-by: zane-neo <[email protected]>
zane-neo added a commit that referenced this pull request Oct 15, 2024
… querying models (#3104)

* Fix PR #2976 bug due to missing adding function_name and algorithm in query models

Signed-off-by: zane-neo <[email protected]>

* format code

Signed-off-by: zane-neo <[email protected]>

* Move the setup mehtod body to test method body

Signed-off-by: zane-neo <[email protected]>

---------

Signed-off-by: zane-neo <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 15, 2024
… querying models (#3104)

* Fix PR #2976 bug due to missing adding function_name and algorithm in query models

Signed-off-by: zane-neo <[email protected]>

* format code

Signed-off-by: zane-neo <[email protected]>

* Move the setup mehtod body to test method body

Signed-off-by: zane-neo <[email protected]>

---------

Signed-off-by: zane-neo <[email protected]>
(cherry picked from commit 5b982c4)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 15, 2024
… querying models (#3104)

* Fix PR #2976 bug due to missing adding function_name and algorithm in query models

Signed-off-by: zane-neo <[email protected]>

* format code

Signed-off-by: zane-neo <[email protected]>

* Move the setup mehtod body to test method body

Signed-off-by: zane-neo <[email protected]>

---------

Signed-off-by: zane-neo <[email protected]>
(cherry picked from commit 5b982c4)
zane-neo added a commit that referenced this pull request Oct 15, 2024
… querying models (#3104) (#3113)

* Fix PR #2976 bug due to missing adding function_name and algorithm in query models

Signed-off-by: zane-neo <[email protected]>

* format code

Signed-off-by: zane-neo <[email protected]>

* Move the setup mehtod body to test method body

Signed-off-by: zane-neo <[email protected]>

---------

Signed-off-by: zane-neo <[email protected]>
(cherry picked from commit 5b982c4)

Co-authored-by: zane-neo <[email protected]>
dhrubo-os pushed a commit that referenced this pull request Oct 15, 2024
… querying models (#3104) (#3114)

* Fix PR #2976 bug due to missing adding function_name and algorithm in query models

Signed-off-by: zane-neo <[email protected]>

* format code

Signed-off-by: zane-neo <[email protected]>

* Move the setup mehtod body to test method body

Signed-off-by: zane-neo <[email protected]>

---------

Signed-off-by: zane-neo <[email protected]>
(cherry picked from commit 5b982c4)

Co-authored-by: zane-neo <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 13, 2024
* Filter out remote model auto redeployment

Signed-off-by: zane-neo <[email protected]>

* format code

Signed-off-by: zane-neo <[email protected]>

---------

Signed-off-by: zane-neo <[email protected]>
(cherry picked from commit e36e58f)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 13, 2024
* Filter out remote model auto redeployment

Signed-off-by: zane-neo <[email protected]>

* format code

Signed-off-by: zane-neo <[email protected]>

---------

Signed-off-by: zane-neo <[email protected]>
(cherry picked from commit e36e58f)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 13, 2024
* Filter out remote model auto redeployment

Signed-off-by: zane-neo <[email protected]>

* format code

Signed-off-by: zane-neo <[email protected]>

---------

Signed-off-by: zane-neo <[email protected]>
(cherry picked from commit e36e58f)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 13, 2024
* Filter out remote model auto redeployment

Signed-off-by: zane-neo <[email protected]>

* format code

Signed-off-by: zane-neo <[email protected]>

---------

Signed-off-by: zane-neo <[email protected]>
(cherry picked from commit e36e58f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants