-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add tutuorial for RAG of openai and bedrock #2975
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Yaliang Wu <[email protected]>
"ext": { | ||
"generative_qa_parameters": { | ||
"llm_model": "bedrock/claude", | ||
"llm_question": "What's the population increase of New York City from 2021 to 2023?", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it a required parameter here? Why don't we use the content of query?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes llm_question
is mandatory , check this doc https://opensearch.org/docs/latest/search-plugins/conversational-search/
This is the feature's design. Some query may have no the content or have different query with the question.
"ext": { | ||
"generative_qa_parameters": { | ||
"llm_model": "bedrock/claude", | ||
"llm_question": "What's the population increase of New York City from 2021 to 2023?", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is a conversational search, can you try a follow up question to demo this is an on-going conversation? Maybe we can try another questions like "based on the population increased in New York, is it the fastest growing city in the world?", or other follow up questions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make sense, will add a following up question
"_id": "2", | ||
"_score": 9.042081, | ||
"_source": { | ||
"text": "Chart and table of population level and growth rate for the New York City metro area from 1950 to 2023. United Nations population projections are also included through the year 2035.\\nThe current metro area population of New York City in 2023 is 18,937,000, a 0.37% increase from 2022.\\nThe metro area population of New York City in 2022 was 18,867,000, a 0.23% increase from 2021.\\nThe metro area population of New York City in 2021 was 18,823,000, a 0.1% increase from 2020.\\nThe metro area population of New York City in 2020 was 18,804,000, a 0.01% decline from 2019." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same comments, wanting to see more queries to demo the conversational features.
Description
Add tutorial for RAG of OpenAI and bedrock
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.