fix field mapping, add more error handling and remove checking jobId … #2933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…filed in batch job response Signed-off-by: Xun Zhang <[email protected]>
Zhangxunmt
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
austintlee,
HenryL27,
sam-herman and
xinyual
as code owners
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
ylwu-amzn
reviewed
Sep 12, 2024
| @@ -75,6 +75,55 @@ protected double calculateSuccessRate(List<Double> successRates) { | |||
| ); | |||
| } | |||
|
|
|||
| /** | |||
| * Filters fields in the map where the value contains the specified source index as a prefix. | |||
| * When there is only one source file, users can skip the source[] prefix | |||
There was a problem hiding this comment.
If there is only one source file, is it ok for cx to input source[0].xxx with this PR ?
There was a problem hiding this comment.
Yes it works for both cases. this function makes sure it finds the fields with source[0] or any fields that does not prefixed with "source".
Signed-off-by: Xun Zhang <[email protected]>
Zhangxunmt
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
Zhangxunmt
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
Zhangxunmt
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
jngz-es
approved these changes
Sep 12, 2024
ylwu-amzn
approved these changes
Sep 12, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 12, 2024
#2933) * fix field mapping, add more error handling and remove checking jobId filed in batch job response Signed-off-by: Xun Zhang <[email protected]> * add beckrock url in the allowed list and more UTs Signed-off-by: Xun Zhang <[email protected]> --------- Signed-off-by: Xun Zhang <[email protected]> (cherry picked from commit 30228ea)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 12, 2024
#2933) * fix field mapping, add more error handling and remove checking jobId filed in batch job response Signed-off-by: Xun Zhang <[email protected]> * add beckrock url in the allowed list and more UTs Signed-off-by: Xun Zhang <[email protected]> --------- Signed-off-by: Xun Zhang <[email protected]> (cherry picked from commit 30228ea)
Zhangxunmt
added a commit
that referenced
this pull request
Sep 12, 2024
#2933) (#2936) * fix field mapping, add more error handling and remove checking jobId filed in batch job response Signed-off-by: Xun Zhang <[email protected]> * add beckrock url in the allowed list and more UTs Signed-off-by: Xun Zhang <[email protected]> --------- Signed-off-by: Xun Zhang <[email protected]> (cherry picked from commit 30228ea) Co-authored-by: Xun Zhang <[email protected]>
Zhangxunmt
added a commit
that referenced
this pull request
Sep 12, 2024
#2933) (#2935) * fix field mapping, add more error handling and remove checking jobId filed in batch job response Signed-off-by: Xun Zhang <[email protected]> * add beckrock url in the allowed list and more UTs Signed-off-by: Xun Zhang <[email protected]> --------- Signed-off-by: Xun Zhang <[email protected]> (cherry picked from commit 30228ea) Co-authored-by: Xun Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…filed in batch job response
Description
This PR fix all problems in #2930
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.