Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.17] Fix RestMLInferenceSearchResponseProcessorIT: add skip when aws key is null #2928

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 93d0429 from #2926

Signed-off-by: Mingshi Liu <[email protected]>
(cherry picked from commit 93d0429)
@mingshl
Copy link
Collaborator

mingshl commented Sep 10, 2024

flaky test

REPRODUCE WITH: gradlew ':opensearch-ml-plugin:integTest' --tests "org.opensearch.ml.rest.RestBedRockInferenceIT.test_bedrock_embedding_model" -Dtests.seed=85CFE7458A9487AF -Dtests.security.manager=false -Dtests.locale=fr-FR -Dtests.timezone=America/Dawson_Creek -Druntime.java=21
org.opensearch.ml.rest.RestBedRockInferenceIT > test_bedrock_embedding_model STANDARD_ERROR
    REPRODUCE WITH: gradlew ':opensearch-ml-plugin:integTest' --tests "org.opensearch.ml.rest.RestBedRockInferenceIT.test_bedrock_embedding_model" -Dtests.seed=85CFE7458A9487AF -Dtests.security.manager=false -Dtests.locale=fr-FR -Dtests.timezone=America/Dawson_Creek -Druntime.java=21

org.opensearch.ml.rest.RestBedRockInferenceIT > test_bedrock_embedding_model FAILED
    java.lang.AssertionError: Failing test case name: without_step_size
        at __randomizedtesting.SeedInfo.seed([85CFE7458A9487AF:A9873A58151B5046]:0)
        at org.junit.Assert.fail(Assert.java:89)
        at org.junit.Assert.assertTrue(Assert.java:42)
        at org.opensearch.ml.rest.RestBedRockInferenceIT.test_bedrock_embedding_model(RestBedRockInferenceIT.java:75)

org.opensearch.ml.rest.RestBedRockInferenceIT > test_bedrock_multimodal_model_empty_imageInput_null_textInput STANDARD_OUT
    [2024-09-10T12:13:02,459][INFO ][o.o.m.r.RestBedRockInferenceIT] [test_bedrock_multimodal_model_empty_imageInput_null_textInput] before test
Error: 24-09-10T12:13:23,483][ERROR][o.o.m.r.MLCommonsRestTestCase] [test_bedrock_multimodal_model_empty_imageInput_null_textInput] method [POST], host [http://127.0.0.1:62596/], URI [/_plugins/_ml/_predict/TEXT_EMBEDDING/mJpa3ZEB91CsNMJB1WwC], status line [HTTP/1.1 400 Bad Request]

@dhrubo-os dhrubo-os merged commit 24fc9c3 into 2.17 Sep 10, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants