-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance: support skip_validating_missing_parameters in connector #2812
Merged
xinyual
merged 4 commits into
opensearch-project:main
from
yuye-aws:Enhance/SkipConnecterParameterValidation
Aug 12, 2024
Merged
Enhance: support skip_validating_missing_parameters in connector #2812
xinyual
merged 4 commits into
opensearch-project:main
from
yuye-aws:Enhance/SkipConnecterParameterValidation
Aug 12, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuye-aws
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
austintlee,
HenryL27,
sam-herman and
xinyual
as code owners
August 8, 2024 03:07
yuye-aws
had a problem deploying
to
ml-commons-cicd-env
August 8, 2024 03:07 — with
GitHub Actions
Failure
yuye-aws
had a problem deploying
to
ml-commons-cicd-env
August 8, 2024 03:07 — with
GitHub Actions
Failure
yuye-aws
force-pushed
the
Enhance/SkipConnecterParameterValidation
branch
from
August 8, 2024 03:26
b2c8be9
to
89fcef5
Compare
yuye-aws
temporarily deployed
to
ml-commons-cicd-env
August 8, 2024 03:26 — with
GitHub Actions
Inactive
yuye-aws
had a problem deploying
to
ml-commons-cicd-env
August 8, 2024 03:26 — with
GitHub Actions
Failure
Signed-off-by: yuye-aws <[email protected]>
yuye-aws
force-pushed
the
Enhance/SkipConnecterParameterValidation
branch
from
August 8, 2024 03:27
89fcef5
to
f9a158e
Compare
yuye-aws
temporarily deployed
to
ml-commons-cicd-env
August 8, 2024 03:27 — with
GitHub Actions
Inactive
yuye-aws
temporarily deployed
to
ml-commons-cicd-env
August 8, 2024 03:28 — with
GitHub Actions
Inactive
Signed-off-by: yuye-aws <[email protected]>
yuye-aws
had a problem deploying
to
ml-commons-cicd-env
August 8, 2024 03:54 — with
GitHub Actions
Failure
yuye-aws
had a problem deploying
to
ml-commons-cicd-env
August 8, 2024 03:54 — with
GitHub Actions
Failure
Signed-off-by: yuye-aws <[email protected]>
yuye-aws
had a problem deploying
to
ml-commons-cicd-env
August 8, 2024 04:08 — with
GitHub Actions
Failure
yuye-aws
had a problem deploying
to
ml-commons-cicd-env
August 8, 2024 04:08 — with
GitHub Actions
Failure
yuye-aws
changed the title
Enhance: skip connecter parameter validation
Enhance: support skip_validating_missing_parameters in connector
Aug 8, 2024
Signed-off-by: yuye-aws <[email protected]>
yuye-aws
temporarily deployed
to
ml-commons-cicd-env
August 8, 2024 05:57 — with
GitHub Actions
Inactive
5 tasks
yuye-aws
temporarily deployed
to
ml-commons-cicd-env
August 8, 2024 05:58 — with
GitHub Actions
Inactive
yuye-aws
temporarily deployed
to
ml-commons-cicd-env
August 8, 2024 07:08 — with
GitHub Actions
Inactive
b4sjoo
approved these changes
Aug 9, 2024
Please help attach backport 2.x label to this PR. Thanks! |
xinyual
approved these changes
Aug 12, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 12, 2024
* introduce skip parameter validation Signed-off-by: yuye-aws <[email protected]> * implement ut Signed-off-by: yuye-aws <[email protected]> * implement it Signed-off-by: yuye-aws <[email protected]> * spotless apply Signed-off-by: yuye-aws <[email protected]> --------- Signed-off-by: yuye-aws <[email protected]> (cherry picked from commit 9663053)
Is this PR for this RFC? |
Yes |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using LLM in ml-commons connector, the prompt may contains substring like
${parameters.xxxx}
. The PRs adds a parameter namedskip_validating_missing_parameters
to enable users to configure whether to skip validating missing parameters in payload.The user can specify this parameter in the following manner:
Related Issues
Resolves #2712
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.