[BugFix] Fix error log to show the right agent type #2809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Heng Qian <[email protected]>
qianheng-aws
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
austintlee,
HenryL27,
sam-herman and
xinyual
as code owners
qianheng-aws
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
qianheng-aws
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
pyek-bot
approved these changes
Oct 11, 2024
|
CI failed, can you check and fix |
It's a flakey failure and unrelated with this PR(testMLInferenceProcessorRemoteModelRewriteQueryString failed with 404). The failure test can succeed in Windows env CI. And it can also succeed in my local mac laptop. |
dhrubo-os
approved these changes
Oct 21, 2024
ylwu-amzn
approved these changes
Oct 21, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 21, 2024
Signed-off-by: Heng Qian <[email protected]> (cherry picked from commit 1bbaddd)
dhrubo-os
pushed a commit
that referenced
this pull request
Oct 21, 2024
Signed-off-by: Heng Qian <[email protected]> (cherry picked from commit 1bbaddd) Co-authored-by: qianheng <[email protected]>
|
@qianheng-aws could you please mark your github email address public so that we don't have DCO failures in the backport PR like this, next time? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When agent runs failed, MLAgentExecutor always show the error log with
Failed to run flow agent, no matter which type the current agent is.Related Issues
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.