Fix version mismatch for http5core #2800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hailong-am
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
Hailong-am
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
|
as http5 is only for main branch, we don't need to backport to 2.x |
Signed-off-by: Hailong Cui <[email protected]>
Hailong-am
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
Hailong-am
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
Hailong-am
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
Hailong-am
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
austintlee,
HenryL27,
sam-herman and
xinyual
as code owners
zane-neo
approved these changes
Aug 2, 2024
xinyual
approved these changes
Aug 5, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Dec 31, 2024
Signed-off-by: Hailong Cui <[email protected]> (cherry picked from commit 90f3f3d)
pyek-bot
pushed a commit
to pyek-bot/ml-commons
that referenced
this pull request
Jan 7, 2025
Signed-off-by: Hailong Cui <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix version mismatch with OpenSearch core, replace hardcode value with variable from core.
this PR will not focus on http5 as it only used for main, 2.x branch use http 4.x
for others dependencies we can have a separate PR that will backpor to 2.x
Related Issues
#2795
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.