Fix ml inference request processor when running terms query #2770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mingshi Liu <[email protected]>
mingshl
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
austintlee,
HenryL27,
sam-herman and
xinyual
as code owners
mingshl
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
mingshl
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
ylwu-amzn
approved these changes
Jul 27, 2024
b4sjoo
reviewed
Jul 27, 2024
plugin/src/main/java/org/opensearch/ml/processor/MLInferenceSearchRequestProcessor.java
Show resolved
Hide resolved
b4sjoo
approved these changes
Jul 27, 2024
mingshl
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 27, 2024
Signed-off-by: Mingshi Liu <[email protected]> (cherry picked from commit d92153b)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 27, 2024
Signed-off-by: Mingshi Liu <[email protected]> (cherry picked from commit d92153b)
b4sjoo
pushed a commit
that referenced
this pull request
Jul 27, 2024
b4sjoo
pushed a commit
that referenced
this pull request
Jul 29, 2024
Signed-off-by: Mingshi Liu <[email protected]> (cherry picked from commit d92153b) Co-authored-by: Mingshi Liu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
remove extra ignoreMissing and fix JsonArray Parsing Issue
when testing terms query on ml inference processor, found the bug when parsing list or other data type in queries are throw parsing exception, this PR will fix the exception while parsing list or object types in query body.
Added unit tests for terms query when matching multiple keywords.
example terms query: {"query":{"terms":{"text":["car","vehicle","truck"],"boost":1.0}}}
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.