Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Add Batch Prediction Mode in the Connector Framework for batch infere… #2701

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

Zhangxunmt
Copy link
Collaborator

Manually backport of #2661

…nce (opensearch-project#2661)

* add batch predict job actiontype in connector

Signed-off-by: Xun Zhang <[email protected]>

* remove async and streaming mode temporarily

Signed-off-by: Xun Zhang <[email protected]>

* rename predict mode to action type

Signed-off-by: Xun Zhang <[email protected]>

* use method name in the url path for action type

Signed-off-by: Xun Zhang <[email protected]>

* add stats for actionType and more UTs

Signed-off-by: Xun Zhang <[email protected]>

* add bwx for actiontype

Signed-off-by: Xun Zhang <[email protected]>

* address more comments

Signed-off-by: Xun Zhang <[email protected]>

---------

Signed-off-by: Xun Zhang <[email protected]>
@dhrubo-os
Copy link
Collaborator

Original PR has 17 files, but in the backport PR has 19 files... what are we changing here?

@dhrubo-os
Copy link
Collaborator

May be for removing those System.out.. we should raise a separate PR to maintain consistency between both branches (main, 2.x). Otherwise we will see more & more backport failing in the long run....

@Zhangxunmt
Copy link
Collaborator Author

Original PR has 17 files, but in the backport PR has 19 files... what are we changing here?

Some leftovers System.out.println() from these two files from other PRs when I was cleaning up the code.

memory/src/test/java/org/opensearch/ml/memory/index/InteractionsIndexTests.java
java/org/opensearch/ml/engine/algorithms/remote/MLSdkAsyncHttpResponseHandlerTest.java

@Zhangxunmt
Copy link
Collaborator Author

May be for removing those System.out.. we should raise a separate PR to maintain consistency between both branches (main, 2.x). Otherwise we will see more & more backport failing in the long run....

Well, this PR is due to the inconsistency from elsewhere between main and 2.x. Since I need to manually backport anyways, let's fix earlier than later. For future changes, they won't need backport if no change in these 2 or 3 files.

@dhrubo-os
Copy link
Collaborator

Original PR has 17 files, but in the backport PR has 19 files... what are we changing here?

Some leftovers System.out.println() from these two files from other PRs when I was cleaning up the code.

memory/src/test/java/org/opensearch/ml/memory/index/InteractionsIndexTests.java java/org/opensearch/ml/engine/algorithms/remote/MLSdkAsyncHttpResponseHandlerTest.java

Approving this PR assuming that you will raise a PR for main with this clean up code to keep the branch code consistent.

@Zhangxunmt Zhangxunmt merged commit 310d023 into opensearch-project:2.x Jul 22, 2024
5 of 11 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 22, 2024
…nce (#2661) (#2701)

* add batch predict job actiontype in connector

* remove async and streaming mode temporarily

* rename predict mode to action type

* use method name in the url path for action type

* add stats for actionType and more UTs

* add bwx for actiontype

* address more comments

---------

Signed-off-by: Xun Zhang <[email protected]>
(cherry picked from commit 310d023)
b4sjoo pushed a commit that referenced this pull request Jul 23, 2024
…nce (#2661) (#2701) (#2705)

* add batch predict job actiontype in connector

* remove async and streaming mode temporarily

* rename predict mode to action type

* use method name in the url path for action type

* add stats for actionType and more UTs

* add bwx for actiontype

* address more comments

---------

Signed-off-by: Xun Zhang <[email protected]>
(cherry picked from commit 310d023)

Co-authored-by: Xun Zhang <[email protected]>
@b4sjoo b4sjoo changed the title [Backport 2661] Add Batch Prediction Mode in the Connector Framework for batch infere… [Backport 2.x] Add Batch Prediction Mode in the Connector Framework for batch infere… Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants