-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] Add Batch Prediction Mode in the Connector Framework for batch infere… #2701
Conversation
…nce (opensearch-project#2661) * add batch predict job actiontype in connector Signed-off-by: Xun Zhang <[email protected]> * remove async and streaming mode temporarily Signed-off-by: Xun Zhang <[email protected]> * rename predict mode to action type Signed-off-by: Xun Zhang <[email protected]> * use method name in the url path for action type Signed-off-by: Xun Zhang <[email protected]> * add stats for actionType and more UTs Signed-off-by: Xun Zhang <[email protected]> * add bwx for actiontype Signed-off-by: Xun Zhang <[email protected]> * address more comments Signed-off-by: Xun Zhang <[email protected]> --------- Signed-off-by: Xun Zhang <[email protected]>
Original PR has 17 files, but in the backport PR has 19 files... what are we changing here? |
May be for removing those |
Some leftovers System.out.println() from these two files from other PRs when I was cleaning up the code. memory/src/test/java/org/opensearch/ml/memory/index/InteractionsIndexTests.java |
Well, this PR is due to the inconsistency from elsewhere between main and 2.x. Since I need to manually backport anyways, let's fix earlier than later. For future changes, they won't need backport if no change in these 2 or 3 files. |
Approving this PR assuming that you will raise a PR for main with this clean up code to keep the branch code consistent. |
…nce (#2661) (#2701) * add batch predict job actiontype in connector * remove async and streaming mode temporarily * rename predict mode to action type * use method name in the url path for action type * add stats for actionType and more UTs * add bwx for actiontype * address more comments --------- Signed-off-by: Xun Zhang <[email protected]> (cherry picked from commit 310d023)
…nce (#2661) (#2701) (#2705) * add batch predict job actiontype in connector * remove async and streaming mode temporarily * rename predict mode to action type * use method name in the url path for action type * add stats for actionType and more UTs * add bwx for actiontype * address more comments --------- Signed-off-by: Xun Zhang <[email protected]> (cherry picked from commit 310d023) Co-authored-by: Xun Zhang <[email protected]>
Manually backport of #2661