add connector blueprint for cohere embedding models in bedrock #2667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xun Zhang <[email protected]>
Zhangxunmt
requested review from
b4sjoo,
dhrubo-os,
jngz-es,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
austintlee,
HenryL27,
sam-herman and
xinyual
as code owners
Zhangxunmt
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
Zhangxunmt
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
|
How about add to https://github.com/opensearch-project/ml-commons/blob/2.x/docs/remote_inference_blueprints/cohere_connector_embedding_blueprint.md, most part should be same ? |
These two are pretty consistent with the current bedrock model blueprints examples. There are separate azure_openai and openai connectors. So why we want to merge them together? Cohere deployed inside Bedrock can be considered as bedrock models too. |
Zhangxunmt
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
ylwu-amzn
reviewed
Jul 17, 2024
| ## 5. Test model inference | ||
|
|
||
| ```json | ||
| POST /_plugins/_ml/models/rcormY8B8aiZvtEZIe89/_predict |
There was a problem hiding this comment.
Can you also try if this API can work ? neural-search requires this API can work
POST /_plugins/_ml/_predict/text_embedding/<model_id>
{
"text_docs":[ "today is sunny", "today is sunny"],
"return_number": true,
"target_response": ["sentence_embedding"]
}
There was a problem hiding this comment.
Yes this is also verified too. It invokes successfully.
Signed-off-by: Xun Zhang <[email protected]>
Zhangxunmt
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
Zhangxunmt
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
ylwu-amzn
reviewed
Jul 17, 2024
docs/remote_inference_blueprints/bedrock_connector_cohere_cohere.embed-english-v3_blueprint.md
Outdated
Show resolved
Hide resolved
ylwu-amzn
reviewed
Jul 17, 2024
...te_inference_blueprints/bedrock_connector_cohere_cohere.embed-multilingual-v3 _blueprint.md
Outdated
Show resolved
Hide resolved
ylwu-amzn
reviewed
Jul 17, 2024
docs/remote_inference_blueprints/bedrock_connector_cohere_cohere.embed-english-v3_blueprint.md
Outdated
Show resolved
Hide resolved
ylwu-amzn
reviewed
Jul 17, 2024
docs/remote_inference_blueprints/bedrock_connector_cohere_cohere.embed-english-v3_blueprint.md
Show resolved
Hide resolved
ylwu-amzn
reviewed
Jul 17, 2024
| "parameters": { | ||
| "region": "<PLEASE ADD YOUR AWS REGION HERE>", | ||
| "service_name": "bedrock", | ||
| "truncate": "<NONE|START|END>", |
There was a problem hiding this comment.
Add some explanation for truncate and input_type?
There was a problem hiding this comment.
Added the AWS doc link to explain all parameters in the latest commit.
ylwu-amzn
reviewed
Jul 17, 2024
...te_inference_blueprints/bedrock_connector_cohere_cohere.embed-multilingual-v3 _blueprint.md
Outdated
Show resolved
Hide resolved
Zhangxunmt
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
Signed-off-by: Xun Zhang <[email protected]>
Zhangxunmt
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
Zhangxunmt
had a problem deploying
to
ml-commons-cicd-env
GitHub Actions
Failure
ylwu-amzn
approved these changes
Jul 18, 2024
b4sjoo
approved these changes
Jul 18, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 18, 2024
* add connector blueprint for cohere embedding models in bedrock Signed-off-by: Xun Zhang <[email protected]> * add neural search way of invoking Signed-off-by: Xun Zhang <[email protected]> * add AWS doc link and update model group names Signed-off-by: Xun Zhang <[email protected]> --------- Signed-off-by: Xun Zhang <[email protected]> (cherry picked from commit 2062a7a)
Zhangxunmt
added a commit
that referenced
this pull request
Jul 18, 2024
#2678) * add connector blueprint for cohere embedding models in bedrock Signed-off-by: Xun Zhang <[email protected]> * add neural search way of invoking Signed-off-by: Xun Zhang <[email protected]> * add AWS doc link and update model group names Signed-off-by: Xun Zhang <[email protected]> --------- Signed-off-by: Xun Zhang <[email protected]> (cherry picked from commit 2062a7a) Co-authored-by: Xun Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Blueprints for cohere embedding models in bedrock.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.