-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add bedrock runtime agent for knowledge base #2651
feat: add bedrock runtime agent for knowledge base #2651
Conversation
Signed-off-by: yuye-aws <[email protected]>
Signed-off-by: yuye-aws <[email protected]>
@@ -144,7 +144,8 @@ private MLCommonsSettings() {} | |||
"^https://runtime\\.sagemaker\\..*[a-z0-9-]\\.amazonaws\\.com/.*$", | |||
"^https://api\\.openai\\.com/.*$", | |||
"^https://api\\.cohere\\.ai/.*$", | |||
"^https://bedrock-runtime\\..*[a-z0-9-]\\.amazonaws\\.com/.*$" | |||
"^https://bedrock-runtime\\..*[a-z0-9-]\\.amazonaws\\.com/.*$", | |||
"^https://bedrock-agent-runtime\\..*[a-z0-9-]\\.amazonaws\\.com/.*$" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we combine these two bedrock endpoint into one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean regex like the following?
^https://(?:bedrock-runtime|bedrock-agent-runtime)\\..*[a-z0-9-]\\.amazonaws\\.com/.*$
But I think the current code is more readable, so I prefer remain unchanged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean bedrock.* to include all bedrock related, so we don't need to add more if there has another bedrock-xyz. I think it's ok to keep as two for now and merge into one if we have more bedrock endpoints comes after.
* add bedrock runtime agent for knowledge base Signed-off-by: yuye-aws <[email protected]> * update unit test Signed-off-by: yuye-aws <[email protected]> --------- Signed-off-by: yuye-aws <[email protected]> (cherry picked from commit 226e53f)
* add bedrock runtime agent for knowledge base Signed-off-by: yuye-aws <[email protected]> * update unit test Signed-off-by: yuye-aws <[email protected]> --------- Signed-off-by: yuye-aws <[email protected]> (cherry picked from commit 226e53f) Co-authored-by: yuye-aws <[email protected]>
Description
Enable users to register bedrock runtime agent for calling bedrock knowledge base.
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.