Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guardrails model support #2491

Merged
merged 5 commits into from
Jun 10, 2024
Merged

Conversation

jngz-es
Copy link
Collaborator

@jngz-es jngz-es commented Jun 2, 2024

Description

Support remote guardrails model to validate user input or LLM output.

Issues Resolved

#2463

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@jngz-es
Copy link
Collaborator Author

jngz-es commented Jun 2, 2024

Hi team, I am adding more UT and IT in this pr, you can review the feature at first.

@jngz-es jngz-es had a problem deploying to ml-commons-cicd-env June 3, 2024 16:27 — with GitHub Actions Error
@jngz-es jngz-es had a problem deploying to ml-commons-cicd-env June 3, 2024 16:27 — with GitHub Actions Error
@jngz-es jngz-es had a problem deploying to ml-commons-cicd-env June 3, 2024 16:27 — with GitHub Actions Failure
@jngz-es jngz-es had a problem deploying to ml-commons-cicd-env June 3, 2024 16:27 — with GitHub Actions Failure
@jngz-es jngz-es had a problem deploying to ml-commons-cicd-env June 3, 2024 16:27 — with GitHub Actions Error
@jngz-es jngz-es had a problem deploying to ml-commons-cicd-env June 3, 2024 16:27 — with GitHub Actions Error
@jngz-es jngz-es had a problem deploying to ml-commons-cicd-env June 3, 2024 17:33 — with GitHub Actions Failure
@jngz-es jngz-es had a problem deploying to ml-commons-cicd-env June 3, 2024 17:33 — with GitHub Actions Error
@jngz-es jngz-es had a problem deploying to ml-commons-cicd-env June 3, 2024 17:33 — with GitHub Actions Failure
@jngz-es jngz-es had a problem deploying to ml-commons-cicd-env June 3, 2024 17:33 — with GitHub Actions Error
@jngz-es jngz-es had a problem deploying to ml-commons-cicd-env June 10, 2024 19:44 — with GitHub Actions Error
@jngz-es jngz-es had a problem deploying to ml-commons-cicd-env June 10, 2024 19:44 — with GitHub Actions Failure
@jngz-es jngz-es temporarily deployed to ml-commons-cicd-env June 10, 2024 20:44 — with GitHub Actions Inactive
@jngz-es jngz-es temporarily deployed to ml-commons-cicd-env June 10, 2024 20:44 — with GitHub Actions Inactive
@jngz-es jngz-es temporarily deployed to ml-commons-cicd-env June 10, 2024 20:44 — with GitHub Actions Inactive
@jngz-es jngz-es temporarily deployed to ml-commons-cicd-env June 10, 2024 20:44 — with GitHub Actions Inactive
@jngz-es jngz-es temporarily deployed to ml-commons-cicd-env June 10, 2024 20:44 — with GitHub Actions Inactive
@jngz-es jngz-es temporarily deployed to ml-commons-cicd-env June 10, 2024 20:44 — with GitHub Actions Inactive
@jngz-es jngz-es temporarily deployed to ml-commons-cicd-env June 10, 2024 21:27 — with GitHub Actions Inactive
@jngz-es jngz-es temporarily deployed to ml-commons-cicd-env June 10, 2024 21:27 — with GitHub Actions Inactive
@jngz-es jngz-es temporarily deployed to ml-commons-cicd-env June 10, 2024 21:27 — with GitHub Actions Inactive
@jngz-es jngz-es had a problem deploying to ml-commons-cicd-env June 10, 2024 21:28 — with GitHub Actions Error
@jngz-es jngz-es had a problem deploying to ml-commons-cicd-env June 10, 2024 21:28 — with GitHub Actions Error
@jngz-es jngz-es had a problem deploying to ml-commons-cicd-env June 10, 2024 21:28 — with GitHub Actions Failure
@jngz-es jngz-es temporarily deployed to ml-commons-cicd-env June 10, 2024 22:26 — with GitHub Actions Inactive
@jngz-es jngz-es temporarily deployed to ml-commons-cicd-env June 10, 2024 22:26 — with GitHub Actions Inactive
@jngz-es jngz-es temporarily deployed to ml-commons-cicd-env June 10, 2024 22:26 — with GitHub Actions Inactive
@jngz-es jngz-es had a problem deploying to ml-commons-cicd-env June 10, 2024 22:26 — with GitHub Actions Failure
@jngz-es jngz-es had a problem deploying to ml-commons-cicd-env June 10, 2024 22:26 — with GitHub Actions Error
@jngz-es jngz-es had a problem deploying to ml-commons-cicd-env June 10, 2024 22:26 — with GitHub Actions Error
@jngz-es jngz-es merged commit a43ba95 into opensearch-project:main Jun 10, 2024
7 of 10 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2491-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a43ba9594cbb0466d215f3206704f59c408fb678
# Push it to GitHub
git push --set-upstream origin backport/backport-2491-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-2491-to-2.x.

jngz-es added a commit to jngz-es/ml-commons that referenced this pull request Jun 11, 2024
* guardrails model support

Signed-off-by: Jing Zhang <[email protected]>

* add IT for remote guardrails model

Signed-off-by: Jing Zhang <[email protected]>

* address comments

Signed-off-by: Jing Zhang <[email protected]>

* address more comments 1

Signed-off-by: Jing Zhang <[email protected]>
ylwu-amzn pushed a commit that referenced this pull request Jun 11, 2024
* guardrails model support



* add IT for remote guardrails model



* address comments



* address more comments 1

Signed-off-by: Jing Zhang <[email protected]>
@jngz-es jngz-es deleted the guardrails branch June 11, 2024 21:14
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 1, 2024
* guardrails model support

* add IT for remote guardrails model

* address comments

* address more comments 1

Signed-off-by: Jing Zhang <[email protected]>
(cherry picked from commit 40c5edc)
dhrubo-os pushed a commit that referenced this pull request Oct 1, 2024
* guardrails model support

* add IT for remote guardrails model

* address comments

* address more comments 1

Signed-off-by: Jing Zhang <[email protected]>
(cherry picked from commit 40c5edc)

Co-authored-by: Jing Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants