-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
guardrails model support #2491
Merged
Merged
guardrails model support #2491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jngz-es
requested review from
b4sjoo,
dhrubo-os,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
austintlee,
HenryL27,
sam-herman and
xinyual
as code owners
June 2, 2024 23:27
jngz-es
had a problem deploying
to
ml-commons-cicd-env
June 2, 2024 23:27 — with
GitHub Actions
Error
jngz-es
had a problem deploying
to
ml-commons-cicd-env
June 2, 2024 23:27 — with
GitHub Actions
Error
jngz-es
had a problem deploying
to
ml-commons-cicd-env
June 2, 2024 23:27 — with
GitHub Actions
Failure
jngz-es
had a problem deploying
to
ml-commons-cicd-env
June 2, 2024 23:27 — with
GitHub Actions
Failure
jngz-es
had a problem deploying
to
ml-commons-cicd-env
June 2, 2024 23:27 — with
GitHub Actions
Error
jngz-es
had a problem deploying
to
ml-commons-cicd-env
June 2, 2024 23:27 — with
GitHub Actions
Error
Hi team, I am adding more UT and IT in this pr, you can review the feature at first. |
jngz-es
had a problem deploying
to
ml-commons-cicd-env
June 3, 2024 16:27 — with
GitHub Actions
Error
jngz-es
had a problem deploying
to
ml-commons-cicd-env
June 3, 2024 16:27 — with
GitHub Actions
Error
jngz-es
had a problem deploying
to
ml-commons-cicd-env
June 3, 2024 16:27 — with
GitHub Actions
Failure
jngz-es
had a problem deploying
to
ml-commons-cicd-env
June 3, 2024 16:27 — with
GitHub Actions
Failure
jngz-es
had a problem deploying
to
ml-commons-cicd-env
June 3, 2024 16:27 — with
GitHub Actions
Error
jngz-es
had a problem deploying
to
ml-commons-cicd-env
June 3, 2024 16:27 — with
GitHub Actions
Error
jngz-es
had a problem deploying
to
ml-commons-cicd-env
June 3, 2024 17:33 — with
GitHub Actions
Failure
jngz-es
had a problem deploying
to
ml-commons-cicd-env
June 3, 2024 17:33 — with
GitHub Actions
Error
jngz-es
had a problem deploying
to
ml-commons-cicd-env
June 3, 2024 17:33 — with
GitHub Actions
Failure
jngz-es
had a problem deploying
to
ml-commons-cicd-env
June 3, 2024 17:33 — with
GitHub Actions
Error
jngz-es
had a problem deploying
to
ml-commons-cicd-env
June 10, 2024 19:44 — with
GitHub Actions
Error
jngz-es
had a problem deploying
to
ml-commons-cicd-env
June 10, 2024 19:44 — with
GitHub Actions
Failure
jngz-es
temporarily deployed
to
ml-commons-cicd-env
June 10, 2024 20:44 — with
GitHub Actions
Inactive
jngz-es
temporarily deployed
to
ml-commons-cicd-env
June 10, 2024 20:44 — with
GitHub Actions
Inactive
jngz-es
temporarily deployed
to
ml-commons-cicd-env
June 10, 2024 20:44 — with
GitHub Actions
Inactive
jngz-es
temporarily deployed
to
ml-commons-cicd-env
June 10, 2024 20:44 — with
GitHub Actions
Inactive
jngz-es
temporarily deployed
to
ml-commons-cicd-env
June 10, 2024 20:44 — with
GitHub Actions
Inactive
jngz-es
temporarily deployed
to
ml-commons-cicd-env
June 10, 2024 20:44 — with
GitHub Actions
Inactive
Signed-off-by: Jing Zhang <[email protected]>
jngz-es
temporarily deployed
to
ml-commons-cicd-env
June 10, 2024 21:27 — with
GitHub Actions
Inactive
jngz-es
temporarily deployed
to
ml-commons-cicd-env
June 10, 2024 21:27 — with
GitHub Actions
Inactive
jngz-es
temporarily deployed
to
ml-commons-cicd-env
June 10, 2024 21:27 — with
GitHub Actions
Inactive
jngz-es
had a problem deploying
to
ml-commons-cicd-env
June 10, 2024 21:28 — with
GitHub Actions
Error
jngz-es
had a problem deploying
to
ml-commons-cicd-env
June 10, 2024 21:28 — with
GitHub Actions
Error
jngz-es
had a problem deploying
to
ml-commons-cicd-env
June 10, 2024 21:28 — with
GitHub Actions
Failure
jngz-es
temporarily deployed
to
ml-commons-cicd-env
June 10, 2024 22:26 — with
GitHub Actions
Inactive
jngz-es
temporarily deployed
to
ml-commons-cicd-env
June 10, 2024 22:26 — with
GitHub Actions
Inactive
jngz-es
temporarily deployed
to
ml-commons-cicd-env
June 10, 2024 22:26 — with
GitHub Actions
Inactive
jngz-es
had a problem deploying
to
ml-commons-cicd-env
June 10, 2024 22:26 — with
GitHub Actions
Failure
jngz-es
had a problem deploying
to
ml-commons-cicd-env
June 10, 2024 22:26 — with
GitHub Actions
Error
jngz-es
had a problem deploying
to
ml-commons-cicd-env
June 10, 2024 22:26 — with
GitHub Actions
Error
ylwu-amzn
approved these changes
Jun 10, 2024
b4sjoo
approved these changes
Jun 10, 2024
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2491-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a43ba9594cbb0466d215f3206704f59c408fb678
# Push it to GitHub
git push --set-upstream origin backport/backport-2491-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
jngz-es
added a commit
to jngz-es/ml-commons
that referenced
this pull request
Jun 11, 2024
* guardrails model support Signed-off-by: Jing Zhang <[email protected]> * add IT for remote guardrails model Signed-off-by: Jing Zhang <[email protected]> * address comments Signed-off-by: Jing Zhang <[email protected]> * address more comments 1 Signed-off-by: Jing Zhang <[email protected]>
ylwu-amzn
pushed a commit
that referenced
this pull request
Jun 11, 2024
* guardrails model support * add IT for remote guardrails model * address comments * address more comments 1 Signed-off-by: Jing Zhang <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 1, 2024
* guardrails model support * add IT for remote guardrails model * address comments * address more comments 1 Signed-off-by: Jing Zhang <[email protected]> (cherry picked from commit 40c5edc)
dhrubo-os
pushed a commit
that referenced
this pull request
Oct 1, 2024
* guardrails model support * add IT for remote guardrails model * address comments * address more comments 1 Signed-off-by: Jing Zhang <[email protected]> (cherry picked from commit 40c5edc) Co-authored-by: Jing Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support remote guardrails model to validate user input or LLM output.
Issues Resolved
#2463
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.