-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix memory CB bugs and upgrade UTs to compatible with core changes #2469
Conversation
…dels Signed-off-by: Xun Zhang <[email protected]>
…2469) * fix memory CB bugs Signed-off-by: Xun Zhang <[email protected]> * change CB limit exception code to 429 and skip CB check for remote models Signed-off-by: Xun Zhang <[email protected]> --------- Signed-off-by: Xun Zhang <[email protected]> (cherry picked from commit f88b6d6)
Long value = (Long) mlStats.getStat(MLNodeLevelStat.ML_CIRCUIT_BREAKER_TRIGGER_COUNT).getValue(); | ||
assertEquals(1L, value.longValue()); | ||
assertEquals(0L, value.longValue()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Name of the test is testRun_CircuitBreakerOpen()
and now we are asserting there's no circuit breaker open. May be we can refactor the name at least?
…2469) (#2472) * fix memory CB bugs Signed-off-by: Xun Zhang <[email protected]> * change CB limit exception code to 429 and skip CB check for remote models Signed-off-by: Xun Zhang <[email protected]> --------- Signed-off-by: Xun Zhang <[email protected]> (cherry picked from commit f88b6d6) Co-authored-by: Xun Zhang <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.11 2.11
# Navigate to the new working tree
cd .worktrees/backport-2.11
# Create a new branch
git switch --create backport/backport-2469-to-2.11
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f88b6d60730afb71f3dce6d3fb65d5f5b085e7bb
# Push it to GitHub
git push --set-upstream origin backport/backport-2469-to-2.11
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.11 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.9 2.9
# Navigate to the new working tree
cd .worktrees/backport-2.9
# Create a new branch
git switch --create backport/backport-2469-to-2.9
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f88b6d60730afb71f3dce6d3fb65d5f5b085e7bb
# Push it to GitHub
git push --set-upstream origin backport/backport-2469-to-2.9
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.9 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.13 2.13
# Navigate to the new working tree
cd .worktrees/backport-2.13
# Create a new branch
git switch --create backport/backport-2469-to-2.13
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f88b6d60730afb71f3dce6d3fb65d5f5b085e7bb
# Push it to GitHub
git push --set-upstream origin backport/backport-2469-to-2.13
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.13 Then, create a pull request where the |
Description
This PR fixed these problems:
deploy
API causes exception from Memory Circuit Breaker #2308Verified in both single-node and multi-node clusters. UT/ITs added to cover all cases.
Issues Resolved
#2308
#2465
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.