add IT flow agent with search index tool #2448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jing Zhang <[email protected]>
jngz-es
requested review from
b4sjoo,
dhrubo-os,
model-collapse,
rbhavna,
ylwu-amzn,
zane-neo,
Zhangxunmt,
austintlee,
HenryL27,
sam-herman and
xinyual
as code owners
jngz-es
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
jngz-es
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
jngz-es
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
jngz-es
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
jngz-es
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
jngz-es
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
jngz-es
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
jngz-es
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
jngz-es
temporarily deployed
to
ml-commons-cicd-env
GitHub Actions
Inactive
Zhangxunmt
reviewed
May 17, 2024
|
|
||
| @Before | ||
| public void setup() throws IOException, ParseException { | ||
| ingestIrisData(irisIndex); |
There was a problem hiding this comment.
Is it possible to merge this IT with RestMLTrainAndPredictIT, to save time in the ingesting irisIndex before and delete it after?
There was a problem hiding this comment.
I prefer to have it in agent IT, as it is for agent framework testing. And it can be reused for other agent test cases.
There was a problem hiding this comment.
LGTM for this test. But I think we can delete RestMLTrainAndPredictIT, and move the tests with new names inside this agentIT to save IT time.
There was a problem hiding this comment.
In my opinion we still need to separate the ITs by its category unless there is obvious concern due to maintainability. Consuming same index doesn't necessarily mean they need to be merged together.
Zhangxunmt
approved these changes
May 17, 2024
b4sjoo
approved these changes
May 17, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 17, 2024
Signed-off-by: Jing Zhang <[email protected]> (cherry picked from commit 99e75aa)
5 tasks
yuye-aws
pushed a commit
to yuye-aws/ml-commons
that referenced
this pull request
Jun 11, 2024
Signed-off-by: Jing Zhang <[email protected]> (cherry picked from commit 99e75aa)
jngz-es
added a commit
that referenced
this pull request
Jun 11, 2024
* add IT flow agent with search index tool (#2448) Signed-off-by: Jing Zhang <[email protected]> (cherry picked from commit 99e75aa) * fix import error (#2527) Signed-off-by: yuye-aws <[email protected]> * Fix:run spotless apply for branch Backport/backport 2448 to 2.x (#2529) * fix import error Signed-off-by: yuye-aws <[email protected]> * spotless apply Signed-off-by: yuye-aws <[email protected]> --------- Signed-off-by: yuye-aws <[email protected]> --------- Signed-off-by: yuye-aws <[email protected]> Co-authored-by: Jing Zhang <[email protected]> Co-authored-by: yuye-aws <[email protected]>
opensearch-trigger-bot bot
added a commit
that referenced
this pull request
Oct 1, 2024
* add IT flow agent with search index tool (#2448) Signed-off-by: Jing Zhang <[email protected]> (cherry picked from commit 99e75aa) * fix import error (#2527) Signed-off-by: yuye-aws <[email protected]> * Fix:run spotless apply for branch Backport/backport 2448 to 2.x (#2529) * fix import error Signed-off-by: yuye-aws <[email protected]> * spotless apply Signed-off-by: yuye-aws <[email protected]> --------- Signed-off-by: yuye-aws <[email protected]> --------- Signed-off-by: yuye-aws <[email protected]> Co-authored-by: Jing Zhang <[email protected]> Co-authored-by: yuye-aws <[email protected]> (cherry picked from commit d6ec823)
dhrubo-os
pushed a commit
that referenced
this pull request
Oct 1, 2024
* add IT flow agent with search index tool (#2448) Signed-off-by: Jing Zhang <[email protected]> (cherry picked from commit 99e75aa) * fix import error (#2527) Signed-off-by: yuye-aws <[email protected]> * Fix:run spotless apply for branch Backport/backport 2448 to 2.x (#2529) * fix import error Signed-off-by: yuye-aws <[email protected]> * spotless apply Signed-off-by: yuye-aws <[email protected]> --------- Signed-off-by: yuye-aws <[email protected]> --------- Signed-off-by: yuye-aws <[email protected]> Co-authored-by: Jing Zhang <[email protected]> Co-authored-by: yuye-aws <[email protected]> (cherry picked from commit d6ec823) Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
IT test case: flow agent + searchIndexTool
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.